mark inter_module_* deprecated
PATCH 1/1 mark inter_module_* deprecated
These had been officially deprecated since Rusty's module rewrite, but never got the __deprecated marker. The only remaining users are drm and mtd, so we'll get some warnings for common builds. But maybe that's the only way to get the drm people to fix the mess :)
include/linux/module.h +7 -5
@@ -580,10 +580,12 @@/* Use symbol_get and symbol_put instead. You'll thank me. */ #define HAVE_INTER_MODULE -extern void inter_module_register (const char *,struct module *,const void *); -extern void inter_module_unregister (const char *); -extern const void *inter_module_get (const char *); -extern const void *inter_module_get_request (const char *,const char *); -extern void inter_module_put (const char *); +extern void __deprecated inter_module_register (const char *, +struct module *,const void *); +extern void __deprecated inter_module_unregister (const char *); +extern const void *__deprecated inter_module_get (const char *); +extern const void *__deprecated inter_module_get_request (const char *, +const char *); +extern void __deprecated inter_module_put (const char *);#endif /* _LINUX_MODULE_H */
Quoted 5 lines · Christoph Hellwig
These had been officially deprecated since Rusty's module rewrite, but never got the
__deprecatedmarker. The only remaining users are drm and mtd, so we'll get some warnings for common builds. But maybe that's the only way to get the drm people to fix the mess :)
It'll piss a few people off but it won't create time, the only thing stopping the drm from getting this stuff out of the way is time, there are two uses in the DRM, one is the agp one, this is easy, Rusty posted a patch for this and I'll probably merge it up after the next kernel release.. the other use requries moving to some sort of DRM in-kernel core, again I'd rather do this at the start of a kernel release cycle as it'll require a bit of testing to make sure we don't break anything....
Most of this stuff is easier if we weren't waiting on Alans vga class support driver to turn up as without it the DRM CVS is blocked, and no DRM developer really wants to start hacking on the vga class stuff as we don't believe it is where our time is best spent until Alan gets code merged into the kernel and gets the fb guys to convert all their drivers... I've already got a patch for converting the DRM to a fixed up version of his last patch...
Dave.
Quoted 7 lines · Dave Airlie
Most of this stuff is easier if we weren't waiting on Alans vga class support driver to turn up as without it the DRM CVS is blocked, and no DRM developer really wants to start hacking on the vga class stuff as we don't believe it is where our time is best spent until Alan gets code merged into the kernel and gets the fb guys to convert all their drivers... I've already got a patch for converting the DRM to a fixed up version of his last patch...
If you've got it working and everyone is happy just submit it. It looks like I'm going to be tty driver hacking for some time yet and you've already done the hardest bit - debugging it.