Skip to contentSkip to conversation

2.6.9-rc2 hangs in posix_locks_deadlock

DISCUSSION Vladimir B. Savkin 2 participants 7 messages Sep 19, 2004 – Oct 30, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I was experiencing kernel hangs with versions 2.6.9-rc2 and 2.6.9-rc2-mm1 on two different boxes.

Today I managed to see the output of Alt+SysRq+P on the hanged box and write down call trace (from screen, so it is incomplete).

EIP (c015da89) was in function posix_locks_deadlock, and the call trace was:
__posix_lock_file
fcntl_setlk

Offending process was saslauthd (version 2.1.15)

~
:wq
With best regards,
Vladimir Savkin.

#1 lore raw
Quoted 2 lines · Vladimir B. Savkin

I was experiencing kernel hangs with versions 2.6.9-rc2 and 2.6.9-rc2-mm1 on two different boxes.

FYI: I have reverted posix-locking-* patches (as found in 2.6.9-rc2-mm1 patch set), no hangs since that.

Quoted 8 lines

Today I managed to see the output of Alt+SysRq+P on the hanged box and write down call trace (from screen, so it is incomplete).

EIP (c015da89) was in function posix_locks_deadlock, and the call trace was:
__posix_lock_file
fcntl_setlk

~
:wq
With best regards,
Vladimir Savkin.

#2 lore raw

På su , 19/09/2004 klokka 13:05, skreiv Vladimir B. Savkin:

Quoted 8 lines
Quoted 8 lines

Today I managed to see the output of Alt+SysRq+P on the hanged box and write down call trace (from screen, so it is incomplete).

EIP (c015da89) was in function posix_locks_deadlock, and the call trace was:
__posix_lock_file
fcntl_setlk

What filesystems are you using on that box?

Cheers,
Trond

#3 lore raw
Quoted 11 lines · Trond Myklebust

P? su , 19/09/2004 klokka 13:05, skreiv Vladimir B. Savkin:

Quoted 8 lines
Quoted 8 lines

Today I managed to see the output of Alt+SysRq+P on the hanged box and write down call trace (from screen, so it is incomplete).

EIP (c015da89) was in function posix_locks_deadlock, and the call trace was:
__posix_lock_file
fcntl_setlk

What filesystems are you using on that box?

reiserfs on all but / and /boot partitions, which are ext2.

~
:wq
With best regards,
Vladimir Savkin.

#4 lore raw

På su , 19/09/2004 klokka 13:36, skreiv Vladimir B. Savkin:

Quoted 10 lines · Trond Myklebust
Quoted 9 lines

P? su , 19/09/2004 klokka 13:05, skreiv Vladimir B. Savkin:

Quoted 8 lines
Quoted 8 lines

Today I managed to see the output of Alt+SysRq+P on the hanged box and write down call trace (from screen, so it is incomplete).

EIP (c015da89) was in function posix_locks_deadlock, and the call trace was:
__posix_lock_file
fcntl_setlk

Hmm... It appears that it is indeed possible for both leases and flocks to be on the global "blocked_list", so the appended check is *not* redundant.
Since flocks in particular do not initialize fl_owner, I suspect that you might be seeing wierd loops that were previously being avoided due to the ->fl_pid checks...

Cheers,
Trond

[PATCH] fix posix_locks_deadlock().

"blocked_list" may contain both leases and flock locks. Since the latter in particular do not initialize the fl_owner field, we have to beware not to call posix_same_owner() on them.

---
 locks.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
fs/locks.c +3 -4
Index: linux-2.6.9-rc2-up/fs/locks.c
===================================================================
@@ -634,14 +634,13 @@
 int posix_locks_deadlock(struct file_lock *caller_fl,
 				struct file_lock *block_fl)
 {
-	struct list_head *tmp;
+	struct file_lock *fl;
 
 next_task:
 	if (posix_same_owner(caller_fl, block_fl))
 		return 1;
-	list_for_each(tmp, &blocked_list) {
-		struct file_lock *fl = list_entry(tmp, struct file_lock, fl_link);
-		if (posix_same_owner(fl, block_fl)) {
+	list_for_each_entry(fl, &blocked_list, fl_link) {
+		if (IS_POSIX(fl) && posix_same_owner(fl, block_fl)) {
 			fl = fl->fl_next;
 			block_fl = fl;
 			goto next_task;
#5 lore raw
Quoted 7 lines · Trond Myklebust

Hmm... It appears that it is indeed possible for both leases and flocks to be on the global "blocked_list", so the appended check is *not* redundant.
Since flocks in particular do not initialize fl_owner, I suspect that you might be seeing wierd loops that were previously being avoided due to the ->fl_pid checks...

Quoted 5 lines

Cheers,
Trond

[PATCH] fix posix_locks_deadlock().

2.6.9-rc2-mm1 with this patch seems to be doing fine, thanks

Quoted 1 line

~
:wq
With best regards,
Vladimir Savkin.

#6 lore raw
In reply to Trond Myklebust
Quoted 6 lines · Trond Myklebust

Hmm... It appears that it is indeed possible for both leases and flocks to be on the global "blocked_list", so the appended check is *not* redundant.
Since flocks in particular do not initialize fl_owner, I suspect that you might be seeing wierd loops that were previously being avoided due to the ->fl_pid checks...

I just noticed that this fix didn't make it into 2.6.9.

Quoted 23 lines

[PATCH] fix posix_locks_deadlock().

"blocked_list" may contain both leases and flock locks. Since the latter in particular do not initialize the fl_owner field, we have to beware not to call posix_same_owner() on them.

---
 locks.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

Index: linux-2.6.9-rc2-up/fs/locks.c
===================================================================

fs/locks.c +1 -1
@@ -634,14 +634,13 @@
 int posix_locks_deadlock(struct file_lock *caller_fl,
 				struct file_lock *block_fl)
 {
-	struct list_head *tmp;
+	struct file_lock *fl;
 
 next_task:

fs/locks.c line 646

Quoted 10 lines
fs/locks.c +2 -3
 	if (posix_same_owner(caller_fl, block_fl))
 		return 1;
-	list_for_each(tmp, &blocked_list) {
-		struct file_lock *fl = list_entry(tmp, struct file_lock, fl_link);
-		if (posix_same_owner(fl, block_fl)) {
+	list_for_each_entry(fl, &blocked_list, fl_link) {
+		if (IS_POSIX(fl) && posix_same_owner(fl, block_fl)) {
 			fl = fl->fl_next;
 			block_fl = fl;
 			goto next_task;

~
:wq
With best regards,
Vladimir Savkin.