Unaligned kernel access in crypto/sha1.c
I got
Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to 0xa0000002001c008e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d005e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d006e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d007e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d008e, ip=0xa0000001002135e0
on ia64 from sha1_transform in crypto/sha1.c:
/* Hash a single 512-bit block. This is the core of the algorithm. */ static void sha1_transform(u32 *state, const u8 *in)
{
u32 a, b, c, d, e;
u32 block32[16];
/* convert/copy data to workspace */
for (a = 0; a < sizeof(block32)/sizeof(u32); a++)
block32[a] = be32_to_cpu (((const u32 *)in)[a]);
^^^^^^^^^^^^^^^^
This may not be aligned for u32 on ia64.H.J.
Quoted 18 lines · H. J. Lu
I got
Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to 0xa0000002001c008e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d005e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d006e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d007e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d008e, ip=0xa0000001002135e0on ia64 from
sha1_transformincrypto/sha1.c:/* Hash a single 512-bit block. This is the core of the algorithm. */ static void
sha1_transform(u32 *state, const u8 *in)
Quoted 11 lines
{
u32 a, b, c, d, e;
u32 block32[16];
/* convert/copy data to workspace */
for (a = 0; a < sizeof(block32)/sizeof(u32); a++)
block32[a] = be32_to_cpu (((const u32 *)in)[a]);
^^^^^^^^^^^^^^^^
This may not be aligned for u32 on ia64.We really need to know the call trace here.
arch/ia64/kernel/unaligned.c renamed from arch/ia64/kernel/unaligned.c~ia64-alignment-error-stack-dump +3 -1
@@ -1342,9 +1342,11 @@ ia64_handle_unaligned (unsigned long ifaprintk (KERN_WARNING "%s" , buf);/* watch for command names containing %s */ } }else { -if (within_logging_rate_limit ()) +if (within_logging_rate_limit ()) {printk (KERN_WARNING "kernel unaligned access to 0x%016lx, ip=0x%016lx\n" , ifa, regs->cr_iip + ipsr->ri); +dump_stack (); + }set_fs (KERNEL_DS ); }
_
Quoted 31 lines · Andrew Morton
Quoted 18 lines · H. J. Lu
I got
Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to 0xa0000002001c008e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d005e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d006e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d007e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d008e, ip=0xa0000001002135e0on ia64 from
sha1_transformincrypto/sha1.c:/* Hash a single 512-bit block. This is the core of the algorithm. */ static void
sha1_transform(u32 *state, const u8 *in)Quoted 11 lines
{ u32 a, b, c, d, e; u32 block32[16]; /* convert/copy data to workspace */ for (a = 0; a < sizeof(block32)/sizeof(u32); a++) block32[a] = be32_to_cpu (((const u32 *)in)[a]); ^^^^^^^^^^^^^^^^ This may not be aligned for u32 on ia64.
Quoted 2 lines
We really need to know the call trace here.
This is from a kernel with signed module support.
kernel unaligned access to 0xa0000002002e47ee, ip=0xa000000100211960
Call Trace:
[<a000000100017490>] show_stack+0x90/0xc0
spà0000017b8cf610
bspà0000017b8c9330
[<a0000001000174f0>] dump_stack+0x30/0x60
spà0000017b8cf7e0
bspà0000017b8c9318
[<a000000100043100>] ia64_handle_unaligned+0x540/0x2600
spà0000017b8cf7e0
bspà0000017b8c9290
[<a0000001000101b0>] ia64_prepare_handle_unaligned+0x30/0x60
spà0000017b8cf990
bspà0000017b8c9290
[<a00000010000fbe0>] ia64_leave_kernel+0x0/0x260
spà0000017b8cfba0
bspà0000017b8c9290
[<a000000100211960>] sha1_transform+0x60/0x3160
spà0000017b8cfd70
bspà0000017b8c9128
[<a000000100214c60>] sha1_update+0x120/0x1a0
spà0000017b8cfda0
bspà0000017b8c90e0
[<a00000010020fd40>] update_kernel+0x60/0x100
spà0000017b8cfda0
bspà0000017b8c90b0
[<a0000001000b3340>] module_verify_sig+0x660/0x740
spà0000017b8cfda0
bspà0000017b8c8ff0
[<a0000001000aed80>] load_module+0x7e0/0x2ba0
spà0000017b8cfda0
bspà0000017b8c8ec0
[<a0000001000b1220>] sys_init_module+0xe0/0x640
spà0000017b8cfe30
bspà0000017b8c8e50
[<a00000010000fa80>] ia64_ret_from_syscall+0x0/0x20
spà0000017b8cfe30
bspà0000017b8c8e50
[<a000000000010620>] 0xa000000000010620
spà0000017b8d0000bspà0000017b8c8e50
Quoted 59 lines · H. J. Lu
Quoted 31 lines · Andrew Morton
Quoted 18 lines · H. J. Lu
I got
Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to 0xa0000002001c008e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d005e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d006e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to 0xa0000002002d007e, ip=0xa0000001002135e0 Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d008e, ip=0xa0000001002135e0on ia64 from
sha1_transformincrypto/sha1.c:/* Hash a single 512-bit block. This is the core of the algorithm. */ static void
sha1_transform(u32 *state, const u8 *in)Quoted 11 lines
{ u32 a, b, c, d, e; u32 block32[16]; /* convert/copy data to workspace */ for (a = 0; a < sizeof(block32)/sizeof(u32); a++) block32[a] = be32_to_cpu (((const u32 *)in)[a]); ^^^^^^^^^^^^^^^^ This may not be aligned for u32 on ia64.Quoted 2 lines
We really need to know the call trace here.
This is from a kernel with signed module support.
kernel unaligned access to
0xa0000002002e47ee, ip=0xa000000100211960Call Trace: [<a000000100017490>] show_stack+0x90/0xc0 spà0000017b8cf610 bspà0000017b8c9330 [<a0000001000174f0>] dump_stack+0x30/0x60 spà0000017b8cf7e0 bspà0000017b8c9318 [<a000000100043100>] ia64_handle_unaligned+0x540/0x2600 spà0000017b8cf7e0 bspà0000017b8c9290 [<a0000001000101b0>] ia64_prepare_handle_unaligned+0x30/0x60 spà0000017b8cf990 bspà0000017b8c9290 [<a00000010000fbe0>] ia64_leave_kernel+0x0/0x260 spà0000017b8cfba0 bspà0000017b8c9290 [<a000000100211960>] sha1_transform+0x60/0x3160 spà0000017b8cfd70bspà0000017b8c9128
Quoted 8 lines
[<a000000100214c60>] sha1_update+0x120/0x1a0
spà0000017b8cfda0
bspà0000017b8c90e0
[<a00000010020fd40>] update_kernel+0x60/0x100
spà0000017b8cfda0
bspà0000017b8c90b0
[<a0000001000b3340>] module_verify_sig+0x660/0x740
spà0000017b8cfda0The bug is in either module_verify_sig() or in update_kernel().
Neither of these functions are present in kernel.org kernels, so there's some sort of lesson there.