Update page-flags.h commentary

PATCH Marcelo Tosatti 2 participants 3 messages Sep 20, 2004

Subsystems (2)

Memory management MM core

lore

Share & tools

lore

Marcelo Tosatti

author

2004-09-20 19:35 UTC #0 lore raw

Andrew,

There is no such thing as "page->age" (this was true sometime back in the past).

Update page-flags to reflect it.

include/linux/page-flags.h renamed from include/linux/page-flags.h.orig +2 -2

@@ -27,8 +27,8 @@
  * For choosing which pages to swap out, inode pages carry a PG_referenced bit,
  * which is set any time the system accesses that page through the (mapping,
  * index) hash table.  This referenced bit, together with the referenced bit
- * in the page tables, is used to manipulate page->age and move the page across
- * the active, inactive_dirty and inactive_clean lists.
+ * in the page tables, is used to move the page across the active, 
+ * inactive_dirty and inactive_clean lists.
  *
  * Note that the referenced bit, the page->lru list_head and the active,
  * inactive_dirty and inactive_clean lists are protected by the

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Christoph Hellwig

2004-09-20 21:41 UTC #1 lore raw

Quoted 10 lines · Marcelo Tosatti

Andrew,
There is no such thing as "page->age" (this was true sometime back in the past).
Update page-flags to reflect it.

include/linux/page-flags.h line 31

Quoted 7 lines

include/linux/page-flags.h renamed from include/linux/page-flags.h.orig +2 -2

@@ -27,8 +27,8 @@
  * For choosing which pages to swap out, inode pages carry a PG_referenced bit,
  * which is set any time the system accesses that page through the (mapping,
  * index) hash table.  This referenced bit, together with the referenced bit
- * in the page tables, is used to manipulate page->age and move the page across
- * the active, inactive_dirty and inactive_clean lists.
+ * in the page tables, is used to move the page across the active, 
+ * inactive_dirty and inactive_clean lists.

there's also no inactive_dirty or inactive_clean lists anymore. Or an mapping, index hashtable..

Marcelo Tosatti

author

2004-09-20 20:30 UTC #2 lore raw

Re: Update page-flags.h commentary\

Quoted 8 lines · Christoph Hellwig

Quoted 7 lines · Marcelo Tosatti
Andrew,
There is no such thing as "page->age" (this was true sometime back in the past).
Update page-flags to reflect it.

Quoted 13 lines

include/linux/page-flags.h line 31

Quoted 10 lines

include/linux/page-flags.h renamed from include/linux/page-flags.h.orig +2 -2

@@ -27,8 +27,8 @@
  * For choosing which pages to swap out, inode pages carry a PG_referenced bit,
  * which is set any time the system accesses that page through the (mapping,
  * index) hash table.  This referenced bit, together with the referenced bit
- * in the page tables, is used to manipulate page->age and move the page across
- * the active, inactive_dirty and inactive_clean lists.
+ * in the page tables, is used to move the page across the active, 
+ * inactive_dirty and inactive_clean lists.

there's also no inactive_dirty or inactive_clean lists anymore. Or an mapping, index hashtable..

True! Andrew, ignore my patch.

If no one prepares a patch I'll do so later on.