message/exec-osm: replace
Subsystems (5)
PATCH 2/4 message/exec-osm: replace
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/message/i2o/exec-osm.c +2 -1
@@ -29,6 +29,7 @@#include <linux/module.h> #include <linux/i2o.h> +#include <linux/delay.h> struct i2o_driver i2o_exec_driver;
@@ -151,7 +152,7 @@ int i2o_msg_post_wait_mem(struct i2o_conprepare_to_wait (&wq, &wait,TASK_INTERRUPTIBLE );if (!iwait->complete) -schedule_timeout (timeout *HZ ); +msleep_interruptible (timeout *1000 );finish_wait (&wq, &wait);
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 2/4 mtd/cfi_cmdset_0001:
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/mtd/chips/cfi_cmdset_0001.c +1 -1
@@ -1649,7 +1649,7 @@ static int do_xxlock_oneblock(struct mapBUG ();spin_unlock (chip->mutex); -schedule_timeout (HZ ); +msleep (1000 );spin_lock (chip->mutex);/* FIXME. Use a timer to check this, and return immediately. */
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 2/4 pci hotplug/cpqphp: replace
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/pci/hotplug/cpqphp.h +1 -2
@@ -707,9 +707,8 @@ static inline int wait_for_ctrl_irq(strudbg ("%s - start\n" , __FUNCTION__);add_wait_queue (&ctrl->queue, &wait); -set_current_state (TASK_INTERRUPTIBLE );/* Sleep for up to 1 second to wait for the LED to change. */ -schedule_timeout (1 *HZ ); +msleep_interruptible (1000 );remove_wait_queue (&ctrl->queue, &wait);if (signal_pending (current)) retval = -EINTR ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 2/4 sbus/bbc_envctrl: replace
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Change the units of POLL_INTERVAL to msecs to correspond to the msleep*() change.
drivers/sbus/char/bbc_envctrl.c +2 -3
@@ -452,7 +452,7 @@ static void fans_full_blast(void) } } -#define POLL_INTERVAL (5 * HZ) +#define POLL_INTERVAL (5 * 1000)static unsigned long last_warning_jiffies;static struct task_struct *kenvctrld_task;
@@ -468,8 +468,7 @@ static int kenvctrld(void *__unused)struct bbc_cpu_temperature *tp;struct bbc_fan_control *fp; - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (POLL_INTERVAL ); +msleep_interruptible (POLL_INTERVAL );if (signal_pending (current))break ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 2/4 w1/w1_family: add
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Inserted set_current_state() before schedule_timeout() so the task delays as expected. Without the insertion, schedule_timeout() will return immediately.
drivers/w1/w1_family.c +3 -1
@@ -84,8 +84,10 @@ void w1_unregister_family(struct w1_famispin_unlock (&w1_flock); -while (atomic_read (&fent->refcnt)) +while (atomic_read (&fent->refcnt)) { +set_current_state (TASK_INTERRUPTIBLE );schedule_timeout (10 ); + } }/*
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors