Skip to contentSkip to conversation

ipv6 limit match does not support invert

PATCH In review Phil Oester 2 participants 2 messages Sep 20, 2004 – Sep 21, 2004 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipv6 limit match does not support invert

Should have included this in earlier ipv4 version, but here is the ipv6 version which clarifies that invert is not supported by limit.

Phil

extensions/libip6t_limit.c +6 -7
diff -ru ipt-orig/extensions/libip6t_limit.c ipt-new/extensions/libip6t_limit.c
@@ -104,19 +104,14 @@
 
 	switch(c) {
 	case '%':
-		if (check_inverse(optarg, &invert, NULL, 0))
-			exit_error(PARAMETER_PROBLEM,
-				   "Unexpected `!' after --limit");
+		if (check_inverse(argv[optind-1], &invert, &optind, 0)) break;
 		if (!parse_rate(optarg, &r->avg))
 			exit_error(PARAMETER_PROBLEM,
 				   "bad rate `%s'", optarg);
 		break;
 
 	case '$':
-		if (check_inverse(optarg, &invert, NULL, 0))
-			exit_error(PARAMETER_PROBLEM,
-				   "Unexpected `!' after --limit-burst");
-
+		if (check_inverse(argv[optind-1], &invert, &optind, 0)) break;
 		if (string_to_number(optarg, 0, 10000, &num) == -1)
 			exit_error(PARAMETER_PROBLEM,
 				   "bad --limit-burst `%s'", optarg);
@@ -127,6 +122,10 @@
 		return 0;
 	}
 
+	if (invert)
+		exit_error(PARAMETER_PROBLEM,
+			   "limit does not support invert");
+
 	return 1;
 }
 
#1 lore raw
Quoted 4 lines · Phil Oester

Should have included this in earlier ipv4 version, but here is the ipv6 version which clarifies that invert is not supported by limit.

All four patches applied, thanks.

Regards
Patrick

Quoted 4 lines

Phil