mtd/cfi_cmdset_0020:
Subsystems (5)
PATCH 4/4 mtd/cfi_cmdset_0020:
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/mtd/chips/cfi_cmdset_0020.c +3 -3
@@ -788,7 +788,7 @@ retry: chip->state =FL_ERASING ;spin_unlock_bh (chip->mutex); -schedule_timeout (HZ ); +msleep (1000 );spin_lock_bh (chip->mutex);/* FIXME. Use a timer to check this, and return immediately. */
@@ -1087,7 +1087,7 @@ retry: chip->state =FL_LOCKING ;spin_unlock_bh (chip->mutex); -schedule_timeout (HZ ); +msleep (1000 );spin_lock_bh (chip->mutex);/* FIXME. Use a timer to check this, and return immediately. */
@@ -1236,7 +1236,7 @@ retry: chip->state =FL_UNLOCKING ;spin_unlock_bh (chip->mutex); -schedule_timeout (HZ ); +msleep (1000 );spin_lock_bh (chip->mutex);/* FIXME. Use a timer to check this, and return immediately. */
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 4/4 pci hotplug/shpchp: replace
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/pci/hotplug/shpchp.h +3 -4
@@ -31,6 +31,7 @@#include <linux/types.h> #include <linux/pci.h> +#include <linux/delay.h> #include <asm/semaphore.h> #include <asm/io.h> #include "pci_hotplug.h"
@@ -381,16 +382,14 @@ static inline int wait_for_ctrl_irq (strdbg ("%s : start\n" ,__FUNCTION__);add_wait_queue (&ctrl->queue, &wait); -set_current_state (TASK_INTERRUPTIBLE );if (!shpchp_poll_mode) {/* Sleep for up to 1 second */ -schedule_timeout (1 *HZ ); +msleep_interruptible (1000 ); }else {/* Sleep for up to 2 seconds */ -schedule_timeout (2 *HZ ); +msleep_interruptible (2000 ); } -set_current_state (TASK_RUNNING );remove_wait_queue (&ctrl->queue, &wait);if (signal_pending (current)) retval = -EINTR ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 4/4 sbus/envctrl: replace
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/sbus/char/envctrl.c +1 -2
@@ -1034,8 +1034,7 @@ static int kenvctrld(void *__unused)printk (KERN_INFO "envctrl: %s starting...\n" , current->comm);for (;;) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (poll_interval); +msleep_interruptible (jiffies_to_msecs (poll_interval));if (signal_pending (current))break ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 4/4 w1/w1: add
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Inserted set_current_state() before schedule_timeout() so the task delays as expected. Without the insertion, schedule_timeout() will return immediately.
drivers/w1/w1.c +3 -1
@@ -446,8 +446,10 @@ static void w1_slave_detach(struct w1_sldev_info (&sl->dev,"%s: detaching %s.\n" , __func__, sl->name); -while (atomic_read (&sl->refcnt)) +while (atomic_read (&sl->refcnt)) { +set_current_state (TASK_INTERRUPTIBLE );schedule_timeout (10 ); + }sysfs_remove_bin_file (&sl->dev.kobj, &sl->attr_bin);device_remove_file (&sl->dev, &sl->attr_name);
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors