Skip to contentSkip to conversation

[Fwd: Minor problem in latest Hotplug package]

Fwd: Minor problem in latest Hotplug package Alexander E. Patrakov 3 participants 5 messages Sep 23, 2004 – Sep 24, 2004 Arm STM32

lore
Share & tools
lore
#0 lore raw

Jeremy Utley and Chris Lingard reported the following problem:

Quoted 1 line

When using the latest hotplug package, it throws up an error from isapnp.rc about returning from a non-source'd function. The return 0 in isapnp.rc should be changed to exit 0.

However, the resulting isapnp.rc is still based on the ancient isapnp.rc from Debian and lacks proper blacklist support. I suggest you to take that file from the latest Debian hotplug package.

There is also an alternative implementation (attached) that supports more modules. The original isapnp.rc from Debian fails to detect even SB16 because snd-sb16 uses MODULE_DEVICE_TABLE(pnp_card, ...), not just pnp.

Signature · 1 line
Alexander E. Patrakov

Submitted By: Alexander E. Patrakov
Date: 2004-09-23
Initial Package Version: 2004_04_01
Origin: based on hotplug-isapnp-0.2.1 by Simone Gotti
Upstream Status: will submit
Description: Replaces ISAPNP hardware detection script with a better version

etc/hotplug/isapnp.aliases +0 -12
diff -urN hotplug-2004_09_20.orig/etc/hotplug/isapnp.aliases hotplug-2004_09_20/etc/hotplug/isapnp.aliases
@@ -1,12 +0,0 @@
-# These aliases are used by /etc/hotplug/isapnp.rc and are needed here
-# because the modules themselves are not providing them.
-alias pnp:dPNP0400 parport_pc
-alias pnp:dPNP0401 parport_pc
-alias pnp:dPNP0510 irtty-sir
-alias pnp:dPNP0511 irtty-sir
-alias pnp:dPNP0700 floppy
-alias pnp:dPNP0800 pcspkr
-alias pnp:dPNP0B00 rtc
-alias pnp:dPNP0303 atkbd
-alias pnp:dPNP0F13 psmouse
-alias pnp:dPNPB02F analog
etc/hotplug/isapnp.rc +0 -60

60 lines not on this page · raw message

etc/hotplug/pnp.distmap +9 -0
diff -urN hotplug-2004_09_20.orig/etc/hotplug/pnp.distmap hotplug-2004_09_20/etc/hotplug/pnp.distmap
@@ -0,0 +1,9 @@
+# isapnp module      cardvendor carddevice driver_data vendor     function   ...
+irtty-sir            0xffff     0xffff     0x00000000  0xd041     0x1005
+irtty-sir            0xffff     0xffff     0x00000000  0xd041     0x1105
+floppy               0xffff     0xffff     0x00000000  0xd041     0x0007    
+pcspkr               0xffff     0xffff     0x00000000  0xd041     0x0008    
+rtc                  0xffff     0xffff     0x00000000  0xd041     0x000b    
+atkbd                0xffff     0xffff     0x00000000  0xd041     0x0303
+psmouse              0xffff     0xffff     0x00000000  0xd041     0x130f
+analog               0xffff     0xffff     0x00000000  0xd041     0x2fb0
etc/hotplug/pnp.rc +119 -0

119 lines not on this page · raw message

#1 lore raw
Quoted 6 lines · Alexander E. Patrakov

Jeremy Utley and Chris Lingard reported the following problem:

Quoted 3 lines

When using the latest hotplug package, it throws up an error from isapnp.rc about returning from a non-source'd function. The return 0 in isapnp.rc should be changed to exit 0.

Quoted 7 lines

However, the resulting isapnp.rc is still based on the ancient isapnp.rc from Debian and lacks proper blacklist support. I suggest you to take that file from the latest Debian hotplug package.

There is also an alternative implementation (attached) that supports more modules. The original isapnp.rc from Debian fails to detect even SB16 because snd-sb16 uses MODULE_DEVICE_TABLE(pnp_card, ...), not just pnp.

Thanks, I've applied this.

It would help if the Debian people actually submitted their packages upstream to me, or just checked them into cvs, as they do have write access to the tree...

thanks,

greg k-h

-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

#2 lore raw
In reply to Alexander E. Patrakov
Quoted 1 line · Greg KH

Thanks, I've applied this.

This sucks, because the code is very different from the one I wrote (which uses new style modprobe aliases instead of maps). :-/

Quoted 3 lines

It would help if the Debian people actually submitted their packages upstream to me, or just checked them into cvs, as they do have write access to the tree...

As I wrote here a few times, they need to be rediffed against the latest release and neither me or Fumitoshi UKAI had time to do this yet.

Signature · 13 lines
ciao, |
Marco | [8143 abUYRcHc.NyFU]


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
#3 lore raw
In reply to Alexander E. Patrakov
Quoted 11 lines · Marco d'Itri
Quoted 3 lines · Greg KH

Thanks, I've applied this.

This sucks, because the code is very different from the one I wrote (which uses new style modprobe aliases instead of maps). :-/

Greg KH made an ambigous statement. What exactly has been applied?

Signature · 12 lines
Alexander E. Patrakov


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
#4 lore raw
In reply to Alexander E. Patrakov
Quoted 6 lines · Alexander E. Patrakov
Quoted 4 lines · Marco d'Itri

On Sep 23, Greg KH <[email protected]> wrote:

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

Thanks, I've applied this.

This sucks, because the code is very different from the one I wrote (which uses new style modprobe aliases instead of maps). :-/

Greg KH made an ambigous statement. What exactly has been applied?

The patch you sent. I applied it and made a new hotplug release on kernel.org with it in it.

If Marco wants to send me some patches as he doesn't agree with your changes, he will, hopefully, some day, do that...

thanks,

greg k-h

-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel