Skip to contentSkip to conversation

net/ixgb_ethtool: replace

PATCH In review Nishanth Aravamudan 1 participant 1 message Sep 23, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 19/38 net/ixgb_ethtool: replace

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

drivers/net/ixgb/ixgb_ethtool.c +2 -3
@@ -441,11 +441,10 @@ ixgb_ethtool_led_blink(struct ixgb_adapt
 
 	mod_timer(&adapter->blink_timer, jiffies);
 
-	set_current_state(TASK_INTERRUPTIBLE);
 	if (id->data)
-		schedule_timeout(id->data * HZ);
+		msleep_interruptible(id->data * 1000);
 	else
-		schedule_timeout(MAX_SCHEDULE_TIMEOUT);
+		msleep_interruptible(jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT));
 
 	del_timer_sync(&adapter->blink_timer);
 	ixgb_led_off(&adapter->hw);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors