net/ma600-sir: replace
Subsystems (2)
PATCH 23/38 net/ma600-sir: replace
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/irda/ma600-sir.c +4 -8
@@ -191,8 +191,7 @@ static int ma600_change_speed(struct sirsirdev_raw_write (dev, &byte,sizeof (byte));/* Wait at least 10ms: fake wait_until_sent - 10 bits at 9600 baud*/ -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (msecs_to_jiffies (15 ));/* old ma600 uses 15ms */ +msleep (15 );/* old ma600 uses 15ms */ #if 1 /* read-back of the control byte. ma600 is the first dongle driver
@@ -215,8 +214,7 @@ static int ma600_change_speed(struct sirsirdev_set_dtr_rts (dev, TRUE, TRUE);/* Wait at least 10ms */ -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (msecs_to_jiffies (10 )); +msleep (10 );/* dongle is now switched to the new speed */ dev->speed = speed;
@@ -245,13 +243,11 @@ int ma600_reset(struct sir_dev *dev)/* Reset the dongle : set DTR low for 10 ms */ sirdev_set_dtr_rts (dev, FALSE, TRUE); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (msecs_to_jiffies (10 )); +msleep (10 );/* Go back to normal mode */ sirdev_set_dtr_rts (dev, TRUE, TRUE); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (msecs_to_jiffies (10 )); +msleep (10 ); dev->speed =9600 ;/* That's the dongle-default */
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors