spinlock sgiwd33 vs spinlock in wd33c93

Hi,
by staring at the code i had the suspicion that the spinlock in the users of the generic wd33c93.c might be obsolete or is my brain too twisted.

     93
     94   spin_lock_irqsave(host->host_lock, flags);
     95   wd33c93_intr(host);
     96   spin_unlock_irqrestore(host->host_lock, flags);
     97

Whereas the wd33c93_intr itself does:

    775         asr = read_aux_stat(regs);
    776         if (!(asr & ASR_INT) || (asr & ASR_BSY))
    777                 return;
    778
    779         spin_lock_irqsave(&hostdata->lock, flags);
    780

It seems all users (gvp, a2091, a3000, sgiwd) do have it except mvme147

Flo

Florian Lohoff                  [email protected]             +49-171-2280134
                        Heisenberg may have been here.