Skip to contentSkip to conversation

2.6.9-rc2-mm2 pcmcia oops

DISCUSSION Lukas Hejtmanek 4 participants 4 messages Sep 26, 2004 – Sep 28, 2004 PCI

lore
Share & tools
lore
#0 lore raw
Unable to handle kernel paging request at virtual address 0000ffff
 printing eip:
c0402097
*pde = 00000000
Oops: 0002 [#1]
PREEMPT 
Modules linked in: yenta_socket pcmcia_core i830 ehci_hcd uhci_hcd rtc
CPU:    0
EIP:    0060:[<c0402097>]    Tainted:  P   VLI
EFLAGS: 00010246   (2.6.9-rc2-mm2) 

EIP is at quirk_usb_early_handoff+0x0/0x3e
eax: 0000ffff ebx: c035d954 ecx: c6866000 edx: 00020000
esi: c6866000 edi: c035da4c ebp: ceede380 esp: c7f4bed8
ds: 007b es: 007b ss: 0068
Process pccardd (pid: 3386, threadinfo=c7f4a000 task=c5ea2d70)

Stack: c01d2076 c6866000 c6866000 ceede380 00000000 c01d20ba c6866000 c035d81c 
       c035da4c c01d01ce 00000000 c6866000 00000000 00000000 c01d0214 ceede380 
       00000000 c686642c ceede380 ceede394 c7f4a000 cfbdd0de ceede380 00000000 
Call Trace:
 [<c01d2076>] pci_do_fixups+0x49/0x4b
 [<c01d20ba>] pci_fixup_device+0x42/0x50
 [<c01d01ce>] pci_scan_single_device+0x37/0x5e
 [<c01d0214>] pci_scan_slot+0x1f/0x60
 [<cfbdd0de>] cb_alloc+0x27/0xe5 [pcmcia_core]
 [<cfbda264>] socket_insert+0xb4/0x151 [pcmcia_core]
 [<cfbda54d>] socket_detect_change+0x58/0x82 [pcmcia_core]
 [<cfbda740>] pccardd+0x1c9/0x245 [pcmcia_core]
 [<c0117179>] default_wake_function+0x0/0x12
 [<c0104ff6>] ret_from_fork+0x6/0x14
 [<c0117179>] default_wake_function+0x0/0x12
 [<cfbda577>] pccardd+0x0/0x245 [pcmcia_core]
 [<c01032a9>] kernel_thread_helper+0x5/0xb
Code: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <00> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Signature · 1 line
Lukáš Hejtmánek
#1 lore raw
Quoted 13 lines · Lukas Hejtmanek
Unable to handle kernel paging request at virtual address 0000ffff
  printing eip:
 c0402097
 *pde = 00000000
 Oops: 0002 [#1]
 PREEMPT 
 Modules linked in: yenta_socket pcmcia_core i830 ehci_hcd uhci_hcd rtc
 CPU:    0
 EIP:    0060:[<c0402097>]    Tainted:  P   VLI
 EFLAGS: 00010246   (2.6.9-rc2-mm2) 
 EIP is at quirk_usb_early_handoff+0x0/0x3e
 eax: 0000ffff   ebx: c035d954   ecx: c6866000   edx: 00020000
Quoted 8 lines
 esi: c6866000   edi: c035da4c   ebp: ceede380   esp: c7f4bed8
 ds: 007b   es: 007b   ss: 0068
 Process pccardd (pid: 3386, threadinfo=c7f4a000 task=c5ea2d70)
 Stack: c01d2076 c6866000 c6866000 ceede380 00000000 c01d20ba c6866000 c035d81c 
        c035da4c c01d01ce 00000000 c6866000 00000000 00000000 c01d0214 ceede380 
        00000000 c686642c ceede380 ceede394 c7f4a000 cfbdd0de ceede380 00000000 
 Call Trace:
  [<c01d2076>] pci_do_fixups+0x49/0x4b

Well quirk_usb_early_handoff() should be __devinit, not __init.

There are a few other things in there which look hotpluggy, and are marked __init. The whole thing needs a review.

drivers/pci/quirks.c renamed from drivers/pci/quirks.c~pci-quirk-section-fixes +4 -4
diff -puN drivers/pci/quirks.c~pci-quirk-section-fixes drivers/pci/quirks.c
@@ -869,7 +869,7 @@ static int __init usb_handoff_early(char
 }
 __setup("usb-handoff", usb_handoff_early);
 
-static void __init quirk_usb_handoff_uhci(struct pci_dev *pdev)
+static void __devinit quirk_usb_handoff_uhci(struct pci_dev *pdev)
 {
 	unsigned long base = 0;
 	int wait_time, delta;
@@ -922,7 +922,7 @@ static void __init quirk_usb_handoff_uhc
 		
 }
 
-static void __init quirk_usb_handoff_ohci(struct pci_dev *pdev)
+static void __devinit quirk_usb_handoff_ohci(struct pci_dev *pdev)
 {
 	void __iomem *base;
 	int wait_time;
@@ -952,7 +952,7 @@ static void __init quirk_usb_handoff_ohc
 	iounmap(base);
 }
 
-static void __init quirk_usb_disable_ehci(struct pci_dev *pdev)
+static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
 {
 	int wait_time, delta;
 	void __iomem *base, *op_reg_base;
@@ -1042,7 +1042,7 @@ static void __init quirk_usb_disable_ehc
 
 
 
-static void __init quirk_usb_early_handoff(struct pci_dev *pdev)
+static void __devinit quirk_usb_early_handoff(struct pci_dev *pdev)
 {
 	if (!usb_early_handoff)
 		return;

_

#2 lore raw
Quoted 1 line · Andrew Morton

Well quirk_usb_early_handoff() should be __devinit, not __init.

I thought we got all those? I guess the recent PCI quirk cleanup reintroduced these bugs.

Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
#3 lore raw
Quoted 5 lines · Russell King
Quoted 1 line · Andrew Morton

Well quirk_usb_early_handoff() should be __devinit, not __init.

I thought we got all those? I guess the recent PCI quirk cleanup reintroduced these bugs.

No, these are new functions added in my trees. I'll go apply Andrew's patch, it is correct.

thanks,

greg k-h