Skip to contentSkip to conversation

Fix x86-64 properly with MSI & Suresh's change

PATCH New Andi Kleen 1 participant 1 message Sep 27, 2004

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Fix x86-64 properly with MSI & Suresh's change

Together with Suresh's recent LH workaround: this patch makes x86-64 compile again with MSI on. i386 uses an CPU number, x86-64 an CPU mask for MSI_TARGET_CPUS and that didn't work very well.

I must admit I don't fully understand how MSI irq affinity is supposed to work (why do you always redirect to the current CPU?), but this matches i386 which is presumably the best tested MSI platform.

include/asm-x86_64/msi.h renamed from include/asm-x86_64/msi.h-o +2 -1
diff -u linux/include/asm-x86_64/msi.h-o linux/include/asm-x86_64/msi.h
@@ -7,10 +7,11 @@
 #define ASM_MSI_H
 
 #include <asm/desc.h>
+#include <asm/smp.h>
 
 #define LAST_DEVICE_VECTOR		232
 #define MSI_DEST_MODE			MSI_LOGICAL_MODE
 #define MSI_TARGET_CPU_SHIFT		12
-#define MSI_TARGET_CPU			TARGET_CPUS
+#define MSI_TARGET_CPU			hard_smp_processor_id()
 
 #endif /* ASM_MSI_H */