Skip to contentSkip to conversation

scsi/sata_sx4: replace

PATCH New Nishanth Aravamudan 1 participant 1 message Sep 27, 2004

Subsystems (3)
SCSI Kernel janitors libata
lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw

PATCH 12/16 scsi/sata_sx4: replace

Any comments would be appreciated.

Description: Use msleep()/ssleep() [as appropriate] instead of schedule_timeout() to guarantee the task delays as expected.

drivers/scsi/sata_sx4.c +2 -4
@@ -1189,8 +1189,7 @@ static unsigned int pdc20621_prog_dimm_g
 	   		error = 0;
 	   		break;     
 		}
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout((i * 100) * HZ / 1000 + 1);
+		msleep(i * 100);
    	}
    	return error;
 }

@@ -1223,8 +1222,7 @@ static unsigned int pdc20621_dimm_init(s
 	readl(mmio + PDC_TIME_CONTROL);
 
 	/* Wait 3 seconds */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(3 * HZ);
+	ssleep(3);
 
 	/* 
 	   When timer is enabled, counter is decreased every internal