Skip to contentSkip to conversation

usb/kaweth: reorder

PATCH New Nishanth Aravamudan 1 participant 1 message Sep 27, 2004

Subsystems (2)
USB Kernel janitors
lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw

PATCH 6/9 usb/kaweth: reorder

Any comments would be appreciated.

Description: Reorder set_current_state() and schedule_timeout() for a minor cleanup. The reorder allows removing two of the set_current_state() calls.

drivers/usb/net/kaweth.c +1 -3
@@ -1250,13 +1250,11 @@ static int usb_start_wait_urb(struct urb
                 return status;
         }
 
-	set_current_state(TASK_UNINTERRUPTIBLE);
 	while (timeout && !awd.done) {
-		timeout = schedule_timeout(timeout);
 		set_current_state(TASK_UNINTERRUPTIBLE);
+		timeout = schedule_timeout(timeout);
 	}
 
-        set_current_state(TASK_RUNNING);
         remove_wait_queue(&awd.wqh, &wait);
 
         if (!timeout) {

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors