ide/ide-cd: replace
Subsystems (5)
PATCH 1/3 ide/ide-cd: replace
Any comments would be appreciated.
Description: Uses msleep() in place of cdrom_sleep() to guarantee the task delays as expected.
drivers/ide/ide-cd.c +1 -14
@@ -1519,19 +1519,6 @@ static ide_startstop_t cdrom_do_packet_c } -/* Sleep for TIME jiffies. -Not to be called from an interrupt handler. */ -static -void cdrom_sleep (int time) -{ -int sleep = time; - -do { -set_current_state (TASK_INTERRUPTIBLE ); - sleep =schedule_timeout (sleep); - }while (sleep); -} -static int cdrom_queue_packet_command (ide_drive_t *drive,struct request *rq) {
@@ -1566,7 +1553,7 @@ int cdrom_queue_packet_command(ide_drive/* The drive is in the process of loading a disk. Retry, but wait a little to give the drive time to complete the load. */ -cdrom_sleep (2 *HZ ); +msleep (2000 ); }else {/* Otherwise, don't retry. */ retries =0 ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/3 macintosh/macserial:
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/macintosh/macserial.c +2 -4
@@ -2002,8 +2002,7 @@ static void rs_close(struct tty_struct *if (info->blocked_open) {if (info->close_delay) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (info->close_delay); +msleep_interruptible (jiffies_to_msecs (info->close_delay)); }wake_up_interruptible (&info->open_wait); }
@@ -2048,8 +2047,7 @@ static void rs_wait_until_sent(struct ttif (timeout) char_time = min_t(unsigned long, char_time, timeout);while ((read_zsreg (info->zs_channel,1 ) &ALL_SNT ) ==0 ) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (char_time); +msleep_interruptible (jiffies_to_msecs (char_time));if (signal_pending (current))break ;if (timeout &&time_after (jiffies, orig_jiffies + timeout))
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/3 md/md: replace
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/md/md.c +1 -2
@@ -3578,8 +3578,7 @@ static void md_do_sync(mddev_t *mddev)if (currspeed > sysctl_speed_limit_min) {if ((currspeed > sysctl_speed_limit_max) || !is_mddev_idle (mddev)) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /4 ); +msleep_interruptible (250 ); goto repeat; } }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/3 parport/ieee1284: replace
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/parport/ieee1284.c +1 -2
@@ -216,8 +216,7 @@ int parport_wait_peripheral(struct parpo/* parport_wait_event didn't time out, but the * peripheral wasn't actually ready either. * Wait for another 10ms. */ -__set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout ((HZ +99 ) /100 ); +msleep_interruptible (10 ); } }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/3 video/radeon_base: replace
In reply to Nishanth AravamudanAny comments would be appreciated.
Description: Use msecs_to_jiffies() instead of the custom MS_TO_HZ().
drivers/video/aty/radeon_base.c +1 -1
@@ -1286,7 +1286,7 @@ static void radeon_write_mode (struct raOUTREG (LVDS_GEN_CNTL , mode->lvds_gen_cntl |LVDS_BLON ); rinfo->pending_lvds_gen_cntl = mode->lvds_gen_cntl;mod_timer (&rinfo->lvds_timer, - jiffies +MS_TO_HZ (rinfo->panel_info.pwr_delay)); + jiffies +msecs_to_jiffies (rinfo->panel_info.pwr_delay)); } } }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors