Skip to contentSkip to conversation

ide/ide-cs: replace

PATCH Applied Nishanth Aravamudan 7 participants 9 messages Sep 16, 2004 – Sep 29, 2004 Kernel janitors

lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw

Sorry, bad description, it

Uses msleep() in place of schedule_timeout() to guarantee the task delays as expected.

Quoted 18 lines · Nishanth Aravamudan

Any comments would be appreciated.

Description: Uses msleep() in place of cdrom_sleep() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/ide/legacy/ide-cs.c +1 -0
@@ -43,6 +43,7 @@
 #include <linux/ide.h>
 #include <linux/hdreg.h>
 #include <linux/major.h>
+#include <linux/delay.h>
 #include <asm/io.h>
 #include <asm/system.h>

drivers/ide/legacy/ide-cs.c void ide_config(dev_link_t *link) · line 364

Quoted 9 lines
drivers/ide/legacy/ide-cs.c +1 -2
@@ -357,8 +358,7 @@ void ide_config(dev_link_t *link)
 		break;
 	    }
 	}
-	__set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(HZ/10);
+	msleep(100);
     }
 
     if (hd < 0) {

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/40] net/act2001-sir:

Quoted 4 lines · Nishanth Aravamudan

Any comments would be appreciated.

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected.

I already said that I don't want this. And looking at other
people getting confused by msleep, I'm more convinced than ever.

	No.

	Thank you.

	Jean

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Applied
#2 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/2] i2c/i2c-mpc: replace

In reply to Nishanth Aravamudan
Quoted 6 lines · Nishanth Aravamudan

Previous patch won't compile. Any comments would (still) be appreciated.

Description: Properly orders set_current_state() and add_wait_queue(). Uses msleep_interruptible() in place of schedule_timeout() to guarantee the task delays as expected. Uses set_current_state() instead of direct assignment of current->state.

Applied, thanks.

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] message/exec-osm:

In reply to Nishanth Aravamudan

Hello,

Quoted 3 lines · Nishanth Aravamudan

Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Thank you very much!

Have changed it.

Best regards,

Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)

Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany

Phone:  +49 82 82/99 51-0
Fax:    +49 82 82/99 51-11
E-Mail: [email protected]
URL:    http://www.shadowconnect.com

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#4 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 22/38] net/ltpc: replace

In reply to Nishanth Aravamudan
Quoted 1 line · Nishanth Aravamudan

Any comments would be appreciated.

OK with me, as the other one for the cyc2x

Quoted 21 lines

Description: Use ssleep() / msleep() [as appropriate] instead of schedule_timeout() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/appletalk/ltpc.c +1 -2
@@ -1109,8 +1109,7 @@ struct net_device * __init ltpc_probe(vo
 	inb_p(io+1);
 	inb_p(io+3);
 
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(2*HZ/100);
+	msleep(20);
 
 	inb_p(io+0);
 	inb_p(io+2);

drivers/net/appletalk/ltpc.c struct net_device * __init ltpc_probe(vo · line 1125

Quoted 9 lines
drivers/net/appletalk/ltpc.c +1 -2
@@ -1120,8 +1119,7 @@ struct net_device * __init ltpc_probe(vo
 	inb_p(io+5); /* enable dma */
 	inb_p(io+6); /* tri-state interrupt line */
 
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(HZ);
+	ssleep(1);
 
 	/* now, figure out which dma channel we're using, unless it's
 	   already been specified */

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#5 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace

In reply to Nishanth Aravamudan
Quoted 4 lines · Nishanth Aravamudan

Any comments would be appreciated.

Description: Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected.

As is pretty clear from the patch, this Description does not match.

Should be:

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Sorry about that.

-Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#6 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 26/38] net/orinoco_plx:

In reply to Nishanth Aravamudan
Quoted 4 lines · Nishanth Aravamudan

Any comments would be appreciated.

Description: Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected.

This change (well, almost, using mdelay() rather than ssleep()) is already in the working CVS tree. I already realise we're long, long overdue on merging upstream.

Signature · 4 lines
David Gibson			| For every complex problem there is a
david AT gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.
http://www.ozlabs.org/people/dgibson

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Applied
#7 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] sbus/bbc_envctrl:

In reply to Nishanth Aravamudan
Quoted 5 lines · On Mon, 27 Sep 2004 10:25:50 -0700 Nishanth Aravamudan <[email protected]> wrote:

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Change the units of POLL_INTERVAL to msecs to correspond to the msleep*() change.

Applied, thanks.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Applied
#8 lore raw

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] pci hotplug/cpqphp:

In reply to Nishanth Aravamudan
Quoted 6 lines · Nishanth Aravamudan

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>

Applied, thanks.

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors