Skip to contentSkip to conversation

tiglusb.c: add direct USB support on some new TI handhelds {Scanned}

PATCH In review Romain Lievin 2 participants 2 messages Sep 28, 2004 – Sep 29, 2004

Subsystems (2)
Documentation USB
lore
Share & tools
lore

Romain Lievin

author
#0 lore raw

PATCH 1/1 tiglusb.c: add direct USB support on some new TI handhelds {Scanned}

Hi,

I have extended my driver to add support of the embedded USB port provided by some new Texas Instruments' handhelds. Things are the same except for the maximum packet size.

Comments are welcome... Otherwise, please apply.

Thanks, Romain.
====================[cut here]=======================

Documentation/usb/silverlink.txt +4 -2
diff -Naur linux-2.6.8.1/Documentation/usb/silverlink.txt linux/Documentation/usb/silverlink.txt
@@ -1,5 +1,6 @@
 -------------------------------------------------------------------------
 Readme for Linux device driver for the Texas Instruments SilverLink cable
+and direct USB cable provided by some TI's handhelds.
 -------------------------------------------------------------------------
 
 Author: Romain Liévin & Julien Blache

@@ -9,7 +10,8 @@
 
 This is a driver for the TI-GRAPH LINK USB (aka SilverLink) cable, a cable 
 designed by TI for connecting their TI8x/9x calculators to a computer 
-(PC or Mac usually).
+(PC or Mac usually). It has been extended to support the USB port offered by
+some latest TI handhelds (TI84+ and TI89 Titanium).
 
 If you need more information, please visit the 'SilverLink drivers' homepage 
 at the above URL.

@@ -73,4 +75,4 @@
 CREDITS:
 
 The code is based on dabusb.c, printer.c and scanner.c !
-The driver has been developed independently of Texas Instruments.
+The driver has been developed independently of Texas Instruments Inc.
drivers/usb/misc/tiglusb.c +42 -16

128 lines not on this page · raw message

drivers/usb/misc/tiglusb.h +2 -6
diff -Naur linux-2.6.8.1/drivers/usb/misc/tiglusb.h linux/drivers/usb/misc/tiglusb.h
@@ -18,12 +18,6 @@
 #define MAXTIGL		16
 
 /*
- * Max. packetsize for IN and OUT pipes
- */
-#define BULK_RCV_MAX	32
-#define BULK_SND_MAX	32
-
-/*
  * The driver context...
  */
 

@@ -42,6 +36,8 @@
 	driver_state_t	state;			/* started/stopped */
 	int		opened;			/* tru if open */
 	int	remove_pending;
+
+	int             max_ps;                 /* max packet size */
 } tiglusb_t, *ptiglusb_t;
 
 #endif
include/linux/ticable.h +2 -0
diff -Naur linux-2.6.8.1/include/linux/ticable.h linux/include/linux/ticable.h
@@ -38,5 +38,7 @@
 #define IOCTL_TIUSB_TIMEOUT        _IOW('N', 0x20, int) /* set timeout */
 #define IOCTL_TIUSB_RESET_DEVICE   _IOW('N', 0x21, int) /* reset device */
 #define IOCTL_TIUSB_RESET_PIPES    _IOW('N', 0x22, int) /* reset both pipes*/
+#define IOCTL_TIUSB_GET_MAXPS      _IOR('N', 0x23, int) /* max packet size */
+#define IOCTL_TIUSB_GET_DEVID      _IOR('N', 0x24, int) /* get device type */
 
 #endif /* TICABLE_H */
Signature · 3 lines
Romain Liévin :		<[email protected]>
Web site :		http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"
#1 lore raw
Quoted 7 lines · Romain Lievin

Hi,

I have extended my driver to add support of the embedded USB port provided by some new Texas Instruments' handhelds. Things are the same except for the maximum packet size.

Comments are welcome... Otherwise, please apply.

Looks ok, but could you please resend it, with the "Signed-off-by:" line added to the description (as per the Documentation/SubmittingPatches file details.) I also got 3 copies of this patch from you, were there any differences in them?

thanks,

greg k-h