Skip to contentSkip to conversation

: fix cpufrequency scaling on ppc

PATCH In review Guido Guenther 2 participants 5 messages Sep 28, 2004 – Sep 30, 2004 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : fix cpufrequency scaling on ppc

Hi,
attached patch against 2.6.9-rc2 fixes cpufrequency scaling after resume on pmacs. Please apply.
-- Guido

arch/ppc/platforms/pmac_cpufreq.c +14 -0
@@ -366,12 +367,26 @@
 	return 0x50 + (*reg);
 }
 
+static unsigned int __pmac pmac_cpufreq_get(unsigned int cpu)
+{
+	if (cpu)
+		return -ENODEV;
+	return	cur_freq;
+}
+
+static struct freq_attr* pmac_cpufreq_attr[] = { 
+        &cpufreq_freq_attr_scaling_available_freqs,
+        NULL,
+};
+
 static struct cpufreq_driver pmac_cpufreq_driver = {
 	.verify 	= pmac_cpufreq_verify,
 	.target 	= pmac_cpufreq_target,
 	.init		= pmac_cpufreq_cpu_init,
+	.get		= pmac_cpufreq_get,
 	.name		= "powermac",
 	.owner		= THIS_MODULE,
+	.attr		= pmac_cpufreq_attr,
 };
 
 
#1 lore raw
Quoted 3 lines · Guido Guenther

Hi,
attached patch against 2.6.9-rc2 fixes cpufrequency scaling after resume on pmacs. Please apply.

It's actually still not clear wether we resume at the same speed we had when going to sleep .. especially in the PMU cpufreq case...

I didn't have time to experiment with this yet tho.

Ben.

#2 lore raw
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 3 lines · Guido Guenther

Hi,
attached patch against 2.6.9-rc2 fixes cpufrequency scaling after resume on pmacs. Please apply.

It's actually still not clear wether we resume at the same speed we had when going to sleep .. especially in the PMU cpufreq case...

Thought about this too, especially since my pbook comes up with the lower frequency after pmdisk resume. Can you think of a simple way to read the current frequency that works an all currently supported models? Cheers,
-- Guido

#3 lore raw
Quoted 11 lines · Guido Guenther
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 3 lines · Guido Guenther

Hi,
attached patch against 2.6.9-rc2 fixes cpufrequency scaling after resume on pmacs. Please apply.

It's actually still not clear wether we resume at the same speed we had when going to sleep .. especially in the PMU cpufreq case...

Thought about this too, especially since my pbook comes up with the lower frequency after pmdisk resume. Can you think of a simple way to read the current frequency that works an all currently supported models?

Nope, unfortunately...

Ben.

#4 lore raw
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 6 lines · Guido Guenther
Quoted 5 lines · Benjamin Herrenschmidt
Quoted 3 lines · Guido Guenther

Hi,
attached patch against 2.6.9-rc2 fixes cpufrequency scaling after resume on pmacs. Please apply.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

It's actually still not clear wether we resume at the same speed we had when going to sleep .. especially in the PMU cpufreq case...

Thought about this too, especially since my pbook comes up with the lower frequency after pmdisk resume. Can you think of a simple way to read the current frequency that works an all currently supported models?

Nope, unfortunately...

Should the patch be applied anyway, it still way better than the current situation.
Cheers,
-- Guido