Skip to contentSkip to conversation

missing tty in sclp_tty.c and sclp_vt220.c

PATCH Olaf Hering 2 participants 2 messages Oct 2, 2004 s390

lore
Share & tools
lore
#0 lore raw

Alan,

what 'tty' did you mean here? gcc says its undeclared.

should that be sclp_tty and sclp_vt220_tty?

drivers/s390/char/sclp_tty.c 2004-09-29 20:07:09 -07:00 +1 -4
diff -Nru a/drivers/s390/char/sclp_tty.c b/drivers/s390/char/sclp_tty.c
@@ -277,10 +277,7 @@
        wake_up(&sclp_tty_waitq);
        /* check if the tty needs a wake up call */
        if (sclp_tty != NULL) {
-               if ((sclp_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-                   sclp_tty->ldisc.write_wakeup)
-                       (sclp_tty->ldisc.write_wakeup)(sclp_tty);
-               wake_up_interruptible(&sclp_tty->write_wait);
+               tty_wakeup(tty);
        }
 }
 
drivers/s390/char/sclp_vt220.c 2004-09-29 20:06:20 -07:00 +1 -4
diff -Nru a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
@@ -139,10 +139,7 @@
        wake_up(&sclp_vt220_waitq);
        /* Check if the tty needs a wake up call */
        if (sclp_vt220_tty != NULL) {
-               if ((sclp_vt220_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-                   (sclp_vt220_tty->ldisc.write_wakeup != NULL))
-                       (sclp_vt220_tty->ldisc.write_wakeup)(sclp_vt220_tty);
-               wake_up_interruptible(&sclp_vt220_tty->write_wait);
+               tty_wakeup(tty);
        }
 }
 
Signature · 3 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG
#1 lore raw
Quoted 2 lines · Olaf Hering

Alan,
should that be sclp_tty and sclp_vt220_tty?

Yes. The patch is correct.