Skip to contentSkip to conversation

snd-usb-usx2y 0.8.2 against alsa-kernel cvshead: OHCI doesn't crash anymore

PATCH New Karsten Wiese 1 participant 1 message Oct 3, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 snd-usb-usx2y 0.8.2 against alsa-kernel cvshead: OHCI doesn't crash anymore

please ignore the snd-usb-usx2y.patch.0.8.1 patch. snd-usb-usx2y.patch.0.8.2 is better by two lines. Text still applies:
----------------------------------------------------------------------------------------
Am Freitag 01 Oktober 2004 15:50 schrieben Sie:

Quoted 1 line

What is the purpose of the replacement with USX2Y_STATIC?

gone now.

Quoted 3 lines

One thing I'm not sure is that the possible race of usX2Y_urbs_start() and usX2Y_subs_startup_finish(). Better to use complete handler?

did I care for any possible racing now?

Best,
Karsten

patch header:

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Summary: Prevents crashes when communicating over ohci usb-hcds.

Work on this started, when rumors spread that ohci equipped machines would crash.
This was due to me missing two facts:
1) Ohci has a bigger usb frame number wrap around.
2) It only supports URB_ISO_ASAP when submitting iso urbs. Fixed now.
Usb-traffic for playback starts now in the prepare callback, like it previously only did for capture.
As a side effect code became simpler and smaller.

<<<<