summary

The next 5 patches update salinfo from 0.5 to 0.6. The complete tarball can be found at ftp://ftp.ocs.com.au:/pub/salinfo-0.6.tar.gz. If Bjorn accepts this update then it will move to ftp://ftp.kernel.org/pub/linux/kernel/people/helgaas/salinfo-0.6.tar.gz.

cleanup         Remove some dead code from salinfo 0.5, mainly from SuSE
logrotate       Use a better method of log rotation
kernel-clear    Handle Ben Woodward's incompatible kernel change in 2.6.9-rc3 
output          Stop stdout and stderr stamping on each other
version         Bump the version to 0.6

Looks good to me. I put it on kernel.org.

By the way, I hear grumbling from neighboring cubes about the colons in the log file names, because it makes it hard to move the files to Windows (HP's log analysis tools are Windows-based).

How much of a hassle would it be if we changed the colons to underscores or something?

Windows - yuck!

Do you want to add this to 0.6 or bump the version to 0.7?

Index: salinfo-0.6/salinfo_decode.c
=================================--- salinfo-0.6.orig/salinfo_decode.c Mon Oct 4 16:04:03 2004
+++ salinfo-0.6/salinfo_decode.c Tue Oct 5 10:49:38 2004
@@ -260,7 +260,7 @@ talk_to_sal (const char *type, const cha

for (suffix = 0; ; ++suffix) {
snprintf(filename, sizeof(filename),
- "%s/raw/%02x%02x-%02x-%02x-%02x:%02x:%02x-cpu%d-%s.%d",
+ "%s/raw/%02x%02x-%02x-%02x-%02x_%02x_%02x-cpu%d-%s.%d",
directory, buffer->timestamp.slh_century, buffer->timestamp.slh_year,
@@ -291,7 +291,7 @@ talk_to_sal (const char *type, const cha
close(fd);

snprintf(filename, sizeof(filename),
- "%s/decoded/%02x%02x-%02x-%02x-%02x:%02x:%02x-cpu%d-%s.%d",
+ "%s/decoded/%02x%02x-%02x-%02x-%02x_%02x_%02x-cpu%d-%s.%d",
directory, buffer->timestamp.slh_century, buffer->timestamp.slh_year,

Yeah, I know :-( But if we can make interoperability easier without screwing up existing users, it seems reasonable.

I made a 0.7 with that patch. Thanks!

ftp://ftp.kernel.org/pub/linux/kernel/people/helgaas/salinfo-0.7.tar.gz