Skip to contentSkip to conversation

snd-usb-usx2y 0.8.3 against alsa-kernel cvshead: OHCI doesn't crash anymore

PATCH In review Karsten Wiese 2 participants 2 messages Oct 4, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 snd-usb-usx2y 0.8.3 against alsa-kernel cvshead: OHCI doesn't crash anymore

please ignore the snd-usb-usx2y.patch.0.8.1 and 0.8.2 patches. snd-usb-usx2y.patch.0.8.2 is better by two lines and 0.8.3 cares for an ohci usb-frame number oddness, where numbers roll from 1 to 0x10000 instead of from 0 to 0xFFFF.
Text still applies:
----------------------------------------------------------------------------------------
Am Freitag 01 Oktober 2004 15:50 schrieben Sie:

Quoted 1 line

What is the purpose of the replacement with USX2Y_STATIC?

gone now.

Quoted 3 lines

One thing I'm not sure is that the possible race of usX2Y_urbs_start() and usX2Y_subs_startup_finish(). Better to use complete handler?

did I care for any possible racing now?

Best,
Karsten

patch header:

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Summary: Prevents crashes when communicating over ohci usb-hcds.

Work on this started, when rumors spread that ohci equipped machines would crash.
This was due to me missing two facts:
1) Ohci has a bigger usb frame number wrap around.
2) It only supports URB_ISO_ASAP when submitting iso urbs. Fixed now.
Usb-traffic for playback starts now in the prepare callback, like it previously only did for capture.
As a side effect code became simpler and smaller.

<<<<

#1 lore raw

Hi Karsten,

Another day, another usx2y patch suite. And another dump of messages :)

These are my latest results on running jackd -R, which still hangs and bails out in less than a minute (jack_watchdog timeout). I can see now really badness going on ;) Take a look on the dmesg outputs attached in the tar.gz archives.

Patches are based on alsa-sound kernel tree as of linux-2.6.9-rc3-mm1(-S8), and applied in the following batch sequence:

For usx2y-0.8.3:

1.+ linux-2.6.9-usx2y-0.8.3.patch.gz

For usx2y-0.8.3a (with new hwdep pcm interface):

2.+ linux-2.6.9-usx2y-0.8.3a.patch.gz
3.+ linux-2.6.9-usx2y-0.8.3a_rawusb.patch.gz

Cheers.

Signature · 2 lines
rncbc aka Rui Nuno Capela
[email protected]