Skip to contentSkip to conversation

PKT_SCHED: Remove useless line in cbq_dump_class

PATCH Applied Thomas Graf 2 participants 3 messages Oct 3, 2004 – Oct 5, 2004

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PKT_SCHED: Remove useless line in cbq_dump_class

Remove useless line in cbq_dump_class probably introduced by copy&paste from cbq_dump.

net/sched/sch_cbq.c +0 -1
@@ -1675,7 +1675,6 @@
 	cl->xstats.undertime = 0;
 	if (!PSCHED_IS_PASTPERFECT(cl->undertime))
 		cl->xstats.undertime = PSCHED_TDIFF(cl->undertime, q->now);
-	q->link.xstats.avgidle = q->link.avgidle;
 	if (cbq_copy_xstats(skb, &cl->xstats)) {
 		spin_unlock_bh(&sch->dev->queue_lock);
 		goto rtattr_failure;
maintainer Applied
#1 lore raw
Quoted 4 lines · On Mon, 4 Oct 2004 00:14:52 +0200 Thomas Graf <[email protected]> wrote:

Remove useless line in cbq_dump_class probably introduced by copy&paste from cbq_dump.

Applied to both 2.4.x and 2.6.x, thanks Thomas.

If you could check quickly whether a 2.6.x patch you post is a relevant bug fix for 2.4.x, that would help me out a lot in processing your patches efficiently.

Thanks.

#2 lore raw

* David S. Miller <[email protected]> 2004-10-05 13:37

Quoted 3 lines

If you could check quickly whether a 2.6.x patch you post is a relevant bug fix for 2.4.x, that would help me out a lot in processing your patches efficiently.

OK, didn't expect we are porting back such minor fixes but will do so in the future.