Skip to contentSkip to conversation

Performance of del_single_shot_timer_sync

RFC PATCH shobhit dayal 2 participants 3 messages Oct 8, 2004 – Oct 10, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines · Andrew Morton

By how much? (CPU load, overall runtime, etc)

It's a bit odd to have an expired-timer-intensive workload. Presumably postgres has some short-lived nanosleep or select-based polling loop in there which isn't doing much.

I am running this load on a numa hardware so I profile the kernel by logging functions that cause remote node memory access. I generate a final log that shows functions that cause remote memory accesses greater that 0.5% of all remote memory access on the system.

del_timer_sync was responsible for about 2% of all remote memory accesses on the system and came up as part of the top 10 functions who were doing this. On top was schedule(7.52%) followed by default_wake_function(2.79%). Rest every one in the top 10 were around the range of 2%.

After the patch it never came up in the logs again( so less than 0.5% of all faulting eip's).

regards
shobhit

Quoted 12 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw
Quoted 13 lines · shobhit dayal
Quoted 5 lines · Andrew Morton

By how much? (CPU load, overall runtime, etc)

It's a bit odd to have an expired-timer-intensive workload. Presumably postgres has some short-lived nanosleep or select-based polling loop in there which isn't doing much.

I am running this load on a numa hardware so I profile the kernel by logging functions that cause remote node memory access. I generate a final log that shows functions that cause remote memory accesses greater that 0.5% of all remote memory access on the system.

Quoted 9 lines

del_timer_sync was responsible for about 2% of all remote memory accesses on the system and came up as part of the top 10 functions who were doing this. On top was schedule(7.52%) followed by default_wake_function(2.79%). Rest every one in the top 10 were around the range of 2%.

After the patch it never came up in the logs again( so less than 0.5% of all faulting eip's).

And what is the overall improvement from the del_timer_sync speedup patch? I mean: overall runtime and CPU time improvements for a relatively-real-world benchmark?

#2 lore raw
Quoted 8 lines · Andrew Morton
Quoted 7 lines · shobhit dayal

del_timer_sync was responsible for about 2% of all remote memory accesses on the system and came up as part of the top 10 functions who were doing this. On top was schedule(7.52%) followed by default_wake_function(2.79%). Rest every one in the top 10 were around the range of 2%.

Quoted 8 lines
Quoted 3 lines

After the patch it never came up in the logs again( so less than 0.5% of all faulting eip's).

And what is the overall improvement from the del_timer_sync speedup patch? I mean: overall runtime and CPU time improvements for a relatively-real-world benchmark?

I have Geoff's figures

Before: 32p 4p

     Warm cache   29,000    505
     Cold cache   37,800   1220

After: 32p 4p
Warm cache 95 88
Cold cache 1,800 140
[Measurements are CPU cycles spent in a call to del_timer_sync, the average of 1000 calls. 32p is 16-node NUMA, 4p is SMP.]

These figures, would apply for the case for where del_timer_sync does get called from del_single_shot_timer_sync. That is del_singe_shot_timer_sync gets called after timer has expired

For my profiling workload i used the standard pg_regress module from the postgres installation and noticed that the ratio of calls to del_single_shot_timer_sync after expiry to before expiry was 10:1. over 11000 calls to del_single_shot_timer_sync.

regards
shobhit