I2C: Spare 1 byte in lm90 driver
PATCH 1/1 I2C: Spare 1 byte in lm90 driver
Hi Greg,
I just noticed the other day that the lm90 driver uses an u16 to store the value of the 8-bit alarms register. This is most probably due to the fact that I originally copied the lm90 driver from the lm83 driver, which actually has two 8-bit registers for alarms, and obviously forgot to change the variable type.
Please apply,
thanks.
drivers/i2c/chips/lm90.c renamed from drivers/i2c/chips/lm90.c.orig +1 -1
@@ -185,7 +185,7 @@s16 temp_input2, temp_low2, temp_high2;/* remote, combined */ s8 temp_crit1, temp_crit2;u8 temp_hyst; -u16 alarms;/* bitvector, combined */ +u8 alarms;/* bitvector */ };/*
Signature · 2 lines
Jean Delvare http://khali.linux-fr.org/
Greg KH
AppliedPATCH 1/1 I2C: Spare 1 byte in lm90 driver
Quoted 9 lines · Jean Delvare
Hi Greg,
I just noticed the other day that the lm90 driver uses an u16 to store the value of the 8-bit alarms register. This is most probably due to the fact that I originally copied the lm90 driver from the lm83 driver, which actually has two 8-bit registers for alarms, and obviously forgot to change the variable type.
Please apply,
Applied, thanks.
greg k-h