Skip to contentSkip to conversation

Enable config_schedstats for all arches

PATCH Chen, Kenneth W 1 participant 1 message Oct 13, 2004 Library code

lore
Share & tools
lore
#0 lore raw

Config option CONFIG_SCHEDSTATS is currently enabled via arch specific Kconfig.debug. Only x86 and ppc arches has code to turn it on. Why not put it in generic lib/Kconfig.debug so it is done once to enable everyone?

arch/i386/Kconfig.debug +0 -12
diff -Nur linux-2.6.9-rc4/arch/i386/Kconfig.debug linux-2.6.9-rc4.new/arch/i386/Kconfig.debug
@@ -55,18 +55,6 @@
 	  on the VM subsystem for higher order allocations. This option
 	  will also use IRQ stacks to compensate for the reduced stackspace.
 
-config SCHEDSTATS
-	bool "Collect scheduler statistics"
-	depends on DEBUG_KERNEL && PROC_FS
-	help
-	  If you say Y here, additional code will be inserted into the
-	  scheduler and related routines to collect statistics about
-	  scheduler behavior and provide them in /proc/schedstat.  These
-	  stats may be useful for both tuning and debugging the scheduler
-	  If you aren't debugging the scheduler or trying to tune a specific
-	  application, you can say N to avoid the very slight overhead
-	  this adds.
-
 config X86_FIND_SMP_CONFIG
 	bool
 	depends on X86_LOCAL_APIC || X86_VOYAGER
arch/ppc/Kconfig.debug +0 -12
diff -Nur linux-2.6.9-rc4/arch/ppc/Kconfig.debug linux-2.6.9-rc4.new/arch/ppc/Kconfig.debug
@@ -53,18 +53,6 @@
 	  Unless you are intending to debug the kernel with one of these
 	  machines, say N here.
 
-config SCHEDSTATS
-	bool "Collect scheduler statistics"
-	depends on DEBUG_KERNEL && PROC_FS
-	help
-	  If you say Y here, additional code will be inserted into the
-	  scheduler and related routines to collect statistics about
-	  scheduler behavior and provide them in /proc/schedstat.  These
-	  stats may be useful for both tuning and debugging the scheduler
-	  If you aren't debugging the scheduler or trying to tune a specific
-	  application, you can say N to avoid the very slight overhead
-	  this adds.
-
 config BOOTX_TEXT
 	bool "Support for early boot text console (BootX or OpenFirmware only)"
 	depends PPC_OF
arch/ppc64/Kconfig.debug +0 -12
diff -Nur linux-2.6.9-rc4/arch/ppc64/Kconfig.debug linux-2.6.9-rc4.new/arch/ppc64/Kconfig.debug
@@ -44,16 +44,4 @@
 	  for handling hard and soft interrupts.  This can help avoid
 	  overflowing the process kernel stacks.
 
-config SCHEDSTATS
-	bool "Collect scheduler statistics"
-	depends on DEBUG_KERNEL && PROC_FS
-	help
-	  If you say Y here, additional code will be inserted into the
-	  scheduler and related routines to collect statistics about
-	  scheduler behavior and provide them in /proc/schedstat.  These
-	  stats may be useful for both tuning and debugging the scheduler
-	  If you aren't debugging the scheduler or trying to tune a specific
-	  application, you can say N to avoid the very slight overhead
-	  this adds.
-
 endmenu
arch/x86_64/Kconfig.debug +0 -12
diff -Nur linux-2.6.9-rc4/arch/x86_64/Kconfig.debug linux-2.6.9-rc4.new/arch/x86_64/Kconfig.debug
@@ -18,18 +18,6 @@
 	  Fill __init and __initdata at the end of boot. This helps debugging
 	  illegal uses of __init and __initdata after initialization.
 
-config SCHEDSTATS
-	bool "Collect scheduler statistics"
-	depends on DEBUG_KERNEL && PROC_FS
-	help
-	  If you say Y here, additional code will be inserted into the
-	  scheduler and related routines to collect statistics about
-	  scheduler behavior and provide them in /proc/schedstat.  These
-	  stats may be useful for both tuning and debugging the scheduler
-	  If you aren't debugging the scheduler or trying to tune a specific
-	  application, you can say N to avoid the very slight overhead
-	  this adds.
-
 config IOMMU_DEBUG
        depends on GART_IOMMU && DEBUG_KERNEL
        bool "Enable IOMMU debugging"
lib/Kconfig.debug +12 -0
diff -Nur linux-2.6.9-rc4/lib/Kconfig.debug linux-2.6.9-rc4.new/lib/Kconfig.debug
@@ -28,6 +28,18 @@
 	  Enables console device to interpret special characters as
 	  commands to dump state information.
 
+config SCHEDSTATS
+	bool "Collect scheduler statistics"
+	depends on DEBUG_KERNEL && PROC_FS
+	help
+	  If you say Y here, additional code will be inserted into the
+	  scheduler and related routines to collect statistics about
+	  scheduler behavior and provide them in /proc/schedstat.  These
+	  stats may be useful for both tuning and debugging the scheduler
+	  If you aren't debugging the scheduler or trying to tune a specific
+	  application, you can say N to avoid the very slight overhead
+	  this adds.
+
 config DEBUG_SLAB
 	bool "Debug memory allocations"
 	depends on DEBUG_KERNEL && (ALPHA || ARM || X86 || IA64 || M68K || MIPS || PARISC || PPC32 || PPC64 || ARCH_S390 || SPARC32

|| SPARC64 || USERMODE || X86_64)