Skip to contentSkip to conversation

janitoring printk with no KERN_ constants, kill all defaults?

DISCUSSION Chuck Ebbert 1 participant 1 message Oct 15, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 11 lines · Dave Jones

Consider this..

      printk (KERN_INFO "blah blah ");
      if (foo)
              printk ("%s", stringptr);
      else
              printk ("%d", number);
      printk ("\n");

There's nothing wrong with any of those printk's, so you cannot do the checks you mention above.

But other code can call printk in between on SMP and/or preempt systems,
making a mess of the log. This is a(n old) problem that should be fixed once and for all, AFAIC.

--Chuck Ebbert 15-Oct-04 13:05:20