Skip to contentSkip to conversation

fix warnings in board/versatile/flash.c

PATCH New Steven Scholz 2 participants 3 messages Oct 18, 2004

lore
Share & tools
lore

Steven Scholz

author
#0 lore raw

PATCH 1/1 fix warnings in board/versatile/flash.c

CHANGELOG:

Fix typo and warning in board/versatile/flash.c

Signature · 5 lines
Steven
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_warning_versatile.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20041018/fe5acc71/attachment.txt
#1 lore raw

PATCH 1/1 fix warnings in board/versatile/flash.c

Dear Steven,

Quoted 3 lines · in message <[email protected]> you wrote:

CHANGELOG:
Fix typo and warning in board/versatile/flash.c

Please check again.

Review

Quoted 2 lines
(quoted diff) +1 -1
-		printf ("\Intel StrataFlash 28F256K3C device initialized\n");
+		printf ("Intel StrataFlash 28F256K3C device initialized\n");

This is already fixed in CVS.

Review

Quoted 2 lines
(quoted diff) +1 -1
-		printf ("not erased at %08lx (%x)\n", (ulong) addr, *addr);
+		printf ("not erased at %08lx (%lx)\n", (ulong) addr, *addr);

I don't get a warning for this code, neither with GCC-2.95.4 nor with GCC-3.3.3. Which toolchain are you using, and what is the error / warning message?

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why is an average signature file longer than an average Perl script??
author
#2 lore raw

PATCH 1/1 fix warnings in board/versatile/flash.c

Dear Wolfgang,

Quoted 6 lines
Quoted 2 lines

CHANGELOG:
Fix typo and warning in board/versatile/flash.c

Please check again.
This is already fixed in CVS.

Yes. Sorry. I just noticed that.

Quoted 6 lines

Review

Quoted 2 lines
(quoted diff) +1 -1
-		printf ("not erased at %08lx (%x)\n", (ulong) addr, *addr);
+		printf ("not erased at %08lx (%lx)\n", (ulong) addr, *addr);

I don't get a warning for this code, neither with GCC-2.95.4 nor with GCC-3.3.3. Which toolchain are you using, and what is the error / warning message?

I am using arm_920TDI-gcc Version 2.95.4 from you ELDK 2.1 and get

flash.c: In function `write_data':
flash.c:479: warning: unsigned int format, long unsigned int arg (arg 3)

--
Steven Scholz