fix it8712 detection
PATCH 1/1 fix it8712 detection
Hello,
Following patch fixes the bug introduced by me in VID VRM patch. Spotted (and later reviewed) by Jean Delvare. This bug is non-fatal, it8712 will be just treated as it was before my VID VRM patch.
Tested on it8705 and it8712 hardware.
Signed-off-by Rudolf Marek <[email protected]>
Thank you.
Regards
Rudolf
drivers/i2c/chips/it87.c +8 -6
@@ -105,6 +105,10 @@/* Reset the registers on init if true */ static int reset; +/* Chip Type */ + +static u16 chip_type; +/* Many IT87 constants specified below */ /* Length of ISA address segment */
@@ -592,9 +596,9 @@u16 val;superio_enter (); - val = (superio_inb (DEVID ) <<8 ) | + chip_type = (superio_inb (DEVID ) <<8 ) |superio_inb (DEVID +1 ); -if (val !=IT8712F_DEVID ) { +if (chip_type !=IT8712F_DEVID ) {superio_exit ();return -ENODEV ; }
@@ -691,11 +695,9 @@if (kind <=0 ) { i =it87_read_value (new_client,IT87_REG_CHIPID );if (i =0x90 ) { -u16 val; kind = it87; - val = (superio_inb (DEVID ) <<8 ) | -superio_inb (DEVID +1 ); -if (val =IT8712F_DEVID ) kind = it8712; +if ((is_isa) && (chip_type =IT8712F_DEVID )) + kind = it8712; }else {if (kind =0 )
Greg KH
AppliedPATCH 1/1 fix it8712 detection
Quoted 10 lines · Rudolf Marek
Hello,
Following patch fixes the bug introduced by me in VID VRM patch. Spotted (and later reviewed) by Jean Delvare. This bug is non-fatal, it8712 will be just treated as it was before my VID VRM patch.
Tested on it8705 and it8712 hardware.
Signed-off-by Rudolf Marek <[email protected]>
Applied, thanks.
greg k-h