Skip to contentSkip to conversation

Add key management syscalls to non-i386 archs

PATCH Andi Kleen 4 participants 4 messages Oct 20, 2004 – Oct 21, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw

include/asm-x86_64/unistd.h __SYSCALL(__NR_mq_getsetattr, sys_mq_get · line 560

Quoted 10 lines · David Howells

/* Syscall protocol:
diff -uNrp linux-2.6.9-bk4/include/asm-x86_64/unistd.h linux-2.6.9-bk4-keys/include/asm-x86_64/unistd.h

include/asm-x86_64/unistd.h +2 -0
@@ -556,8 +556,14 @@ __SYSCALL(__NR_mq_getsetattr, sys_mq_get
 __SYSCALL(__NR_kexec_load, sys_ni_syscall)
 #define __NR_waitid		247
 __SYSCALL(__NR_waitid, sys_waitid)
+#define __NR_add_key		248
+__SYSCALL(__NR_add_key, sys_add_key)

Hey, I already allocated 248 for setaltroot. And no, you cannot allocate system calls on your own without going through the architecture maintainer. The normal workflow is that you add them to i386 and the other follow on their own.

Andrew, please don't apply the x86-64 parts of this.

-Andi

#2 lore raw
Quoted 4 lines

Hey, I already allocated 248 for setaltroot. And no, you cannot allocate system calls on your own without going through the architecture maintainer. The normal workflow is that you add them to i386 and the other follow on their own.

That's what I intended, but others, especially Arjan, seem to think I should do all the compat stuff for all archs myself.

David

#3 lore raw
Quoted 2 lines · David Howells
Quoted 2 lines

Hey, I already allocated 248 for setaltroot.

I wouldn't be in a rush to wire up sys_altroot() actually. Unless some security issues are resolved it's going away again.

#4 lore raw
In reply to David Howells
Quoted 7 lines · David Howells
Quoted 4 lines

Hey, I already allocated 248 for setaltroot. And no, you cannot allocate system calls on your own without going through the architecture maintainer. The normal workflow is that you add them to i386 and the other follow on their own.

That's what I intended, but others, especially Arjan, seem to think I should do all the compat stuff for all archs myself.

eh please don't abuse my name like that.
I asked for ONE compat emulation thing to show it can be done, that's not the same as asking for butchering every arch.