Skip to contentSkip to conversation

acpi-thermal: fix confusing define

PATCH Applied Pavel Machek 2 participants 2 messages Oct 20, 2004 1 message not in the archive

Subsystems (2)
ACPI ACPI thermal driver
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

We have PASSIVE, ACTIVE and CRT cooling policies... Ouch, the last one should probably be called CRITICAL otherwise everyone thinks "TV?". This patch fixes it, please apply,
Pavel

drivers/acpi/thermal.c +3 -3
@@ -60,8 +60,8 @@
 #define ACPI_THERMAL_NOTIFY_HOT		0xF1
 #define ACPI_THERMAL_MODE_ACTIVE	0x00
 #define ACPI_THERMAL_MODE_PASSIVE	0x01
-#define ACPI_THERMAL_MODE_CRT   	0xff
+#define ACPI_THERMAL_MODE_CRITICAL		0xff
 #define ACPI_THERMAL_PATH_POWEROFF	"/sbin/poweroff"
 
 #define ACPI_THERMAL_MAX_ACTIVE	10
 

@@ -953,7 +964,7 @@
 		seq_puts(seq, "<setting not supported>\n");
 	}
 
-	if ( tz->cooling_mode == ACPI_THERMAL_MODE_CRT )
+	if ( tz->cooling_mode == ACPI_THERMAL_MODE_CRITICAL )
 		seq_printf(seq, "cooling mode:	critical\n");
 	else
 		seq_printf(seq, "cooling mode:	%s\n",

@@ -1262,7 +1276,7 @@
 			tz->cooling_mode = ACPI_THERMAL_MODE_ACTIVE;
 		} else {
 			/* _ACx and _PSV are optional, but _CRT is required */
-			tz->cooling_mode = ACPI_THERMAL_MODE_CRT;
+			tz->cooling_mode = ACPI_THERMAL_MODE_CRITICAL;
 		}
 	}
Signature · 9 lines
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

A message that is not in the archive (sent off-list or not yet received): 20041020181221.GA25015-I/[email protected]

Applied
#2 lore raw

applied.

thanks,
-len

Quoted 39 lines · Pavel Machek

Hi!

We have PASSIVE, ACTIVE and CRT cooling policies... Ouch, the last one should probably be called CRITICAL otherwise everyone thinks "TV?". This patch fixes it, please apply,
Pavel

drivers/acpi/thermal.c 20 Oct 2004 17:53:41 -0000 renamed from drivers/acpi/thermal.c 9 Oct 2004 04:09:18 -0000 1.27 +2 -2
@@ -60,8 +60,8 @@
 #define ACPI_THERMAL_NOTIFY_HOT                0xF1
 #define ACPI_THERMAL_MODE_ACTIVE       0x00
 #define ACPI_THERMAL_MODE_PASSIVE      0x01
-#define ACPI_THERMAL_MODE_CRT          0xff
+#define ACPI_THERMAL_MODE_CRITICAL             0xff
 #define ACPI_THERMAL_PATH_POWEROFF     "/sbin/poweroff"
 
 #define ACPI_THERMAL_MAX_ACTIVE        10
 

@@ -953,7 +964,7 @@
                seq_puts(seq, "<setting not supported>\n");
        }
 
-       if ( tz->cooling_mode == ACPI_THERMAL_MODE_CRT )
+       if ( tz->cooling_mode == ACPI_THERMAL_MODE_CRITICAL )
                seq_printf(seq, "cooling mode:  critical\n");
        else
                seq_printf(seq, "cooling mode:  %s\n",

@@ -1262,7 +1276,7 @@
                        tz->cooling_mode = ACPI_THERMAL_MODE_ACTIVE;
                } else {
                        /* _ACx and _PSV are optional, but _CRT is

required */

drivers/acpi/thermal.c 20 Oct 2004 17:53:41 -0000 renamed from drivers/acpi/thermal.c 9 Oct 2004 04:09:18 -0000 1.27 +1 -2
-                       tz->cooling_mode = ACPI_THERMAL_MODE_CRT;
+                       tz->cooling_mode = ACPI_THERMAL_MODE_CRITICAL;
                }
        }
 
--
Quoted 4 lines

People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl