Skip to contentSkip to conversation

accept should return ENFILE if it runs out of inodes

PATCH Andrea Arcangeli 2 participants 2 messages Oct 21, 2004 – Oct 26, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

EMFILE is only for the per-process fds limit, all other cases where sock_alloc fails already returns -ENFILE too, must have been a typo.

patch for 2.4:

net/socket.c renamed from net/socket.c.~1~ +1 -1
@@ -1068,7 +1068,7 @@ asmlinkage long sys_accept(int fd, struc
 	if (!sock)
 		goto out;
 
-	err = -EMFILE;
+	err = -ENFILE;
 	if (!(newsock = sock_alloc())) 
 		goto out_put;
 

patch for 2.6:

Index: linux-2.5/net/socket.c
===================================================================
RCS file: /home/andrea/crypto/cvs/linux-2.5/net/socket.c,v retrieving revision 1.90

net/socket.c +1 -1
diff -u -p -r1.90 socket.c
@@ -1354,7 +1354,7 @@ asmlinkage long sys_accept(int fd, struc
 	if (!sock)
 		goto out;
 
-	err = -EMFILE;
+	err = -ENFILE;
 	if (!(newsock = sock_alloc())) 
 		goto out_put;
 
maintainer
#1 lore raw
Quoted 2 lines · On Thu, 21 Oct 2004 02:41:27 +0200 Andrea Arcangeli <[email protected]> wrote:

EMFILE is only for the per-process fds limit, all other cases where sock_alloc fails already returns -ENFILE too, must have been a typo.

Fix applied to both 2.4.x and 2.6.x, thanks Andrea.