Skip to contentSkip to conversation

2.6.9: allow config to specify custom DSDT (Ulf Dambacher)

OT Applied Zhu, Yi 5 participants 6 messages Oct 22, 2004 – Oct 29, 2004 1 message not in the archive ACPI

lore
Share & tools
lore

Zhu, Yi

author
#0 lore raw

Hi,

How about the DSDT_INITRD patch in SuSE kernel? I think it is cleaner than this one.
What do you think?

Thanks,
-yi

Quoted 7 lines · Len Brown

Note that CONFIG_ACPI_CUSTOM_DSDT depends on CONFIG_STANDALONE=n

The reason is that otherwise the allmodconfig and
allyesconfig builds break.

thanks,
-Len

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

#1 lore raw

It has always been a mistake for SuSE to include that patch, because an OSD can't possibly support modified OEM firmware.

DSDT overrides are for developers and experimentation, not for production use. Developers know how to build kernels, and those that don't use initrd's can't use the initrd method anyway.

The only argument for the initrd patch I've heard is from somebody who deploys and supports the same kernel on multiple systems, each with different DSDT patches. I recommend that they choose their hardware vendor more carefully in the future.

Also, the initrd pach isn't "clean" -- there isn't a supported interface for appending junk onto an initrd, it is a hack to do so with magic strings.

-Len

Quoted 17 lines · Yi

Hi,

How about the DSDT_INITRD patch in SuSE kernel? I think it is cleaner than this one.
What do you think?

Thanks,
-yi

Quoted 7 lines · Len Brown

Note that CONFIG_ACPI_CUSTOM_DSDT depends on CONFIG_STANDALONE=n

The reason is that otherwise the allmodconfig and
allyesconfig builds break.

thanks,
-Len

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

#2 lore raw
Quoted 2 lines · Len Brown

I recommend that they choose their hardware vendor more carefully in the future.

You don't have always the *choice* of the hardware vendor (though I never have to override DSDT in servers for now).

Signature · 11 lines
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
#3 lore raw

PATCH 1/1 Allow ACPI_CUSTOM_DSDT for IA64

In reply to Len Brown
Quoted 4 lines · Len Brown

DSDT overrides are for developers and experimentation, not for production use. Developers know how to build kernels, and those that don't use initrd's can't use the initrd method anyway.

Hi Len,
Currently DSDT override patch is available only on X86 and
this is required for IA64 too.

The attached patch(for 2.6.10-rc1)make this option available on IA64. Will you please consider applying this path.

---

 linux-2.6.10-rc1-askeshav/drivers/acpi/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig renamed from drivers/acpi/Kconfig~config_dsdt +1 -1
diff -puN drivers/acpi/Kconfig~config_dsdt drivers/acpi/Kconfig
@@ -215,7 +215,7 @@ config ACPI_TOSHIBA
 
 config ACPI_CUSTOM_DSDT
 	bool "Include Custom DSDT"
-	depends on X86 && ACPI_INTERPRETER && !STANDALONE
+	depends on ACPI_INTERPRETER && !STANDALONE
 	default n 
 	help
 	  Thist option is to load a custom ACPI DSDT

_

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

A message that is not in the archive (sent off-list or not yet received): 20041025134914.A8649-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org

Applied
#5 lore raw

Re: [PATCH] Allow ACPI_CUSTOM_DSDT for IA64

Applied.

thanks,
-Len

Quoted 32 lines · Keshavamurthy Anil S
Quoted 4 lines · Len Brown

DSDT overrides are for developers and experimentation, not for production use. Developers know how to build kernels, and those that don't use initrd's can't use the initrd method anyway.

Hi Len,
Currently DSDT override patch is available only on X86 and
this is required for IA64 too.

The attached patch(for 2.6.10-rc1)make this option available on IA64. Will you please consider applying this path.

---

 linux-2.6.10-rc1-askeshav/drivers/acpi/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/acpi/Kconfig~config_dsdt drivers/acpi/Kconfig
--- linux-2.6.10-rc1/drivers/acpi/Kconfig~config_dsdt 2004-10-25
13:43:37.078238831 -0700
+++ linux-2.6.10-rc1-askeshav/drivers/acpi/Kconfig 2004-10-25
13:45:31.171987433 -0700

drivers/acpi/Kconfig renamed from drivers/acpi/Kconfig~config_dsdt +1 -1
@@ -215,7 +215,7 @@ config ACPI_TOSHIBA
 
 config ACPI_CUSTOM_DSDT
        bool "Include Custom DSDT"
-       depends on X86 && ACPI_INTERPRETER && !STANDALONE
+       depends on ACPI_INTERPRETER && !STANDALONE
        default n
        help
          Thist option is to load a custom ACPI DSDT
Quoted 3 lines

_

-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

#6 lore raw
In reply to Len Brown
Quoted 2 lines · Len Brown

It has always been a mistake for SuSE to include that patch, because an OSD can't possibly support modified OEM firmware.

Well, you know, there are also basically "unsupported" SUSE releases, namely the box products. And there it is nice to be able to override the DSDT with a simple "mk_initrd" without having to recompile the Kernel _and_ all additional drivers. You know, the nice 3d drivers or the wireless drivers or...

Of course the customer is on its own if he is running with a patched DSDT, but he is also on his own if he is _not_ but then with a non-working machine.

Quoted 3 lines

Also, the initrd pach isn't "clean" -- there isn't a supported interface for appending junk onto an initrd, it is a hack to do so with magic strings.

This is something one could change if there was an agreement on how to do it right and "clean".

Signature · 9 lines
Stefan Seyfried



-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click