Skip to contentSkip to conversation

block/pktcdvd: set_current_state() location

KJ Nishanth Aravamudan 1 participant 1 message Oct 22, 2004 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Jens & Peter,

I was looking through 2.6.9-bk7 with the latest kjt (Kernel-Janitors patchset) applied and noticed a new schedule_timeout() in the code. In drivers/block/pktcdvd.c::kcdrwd(), the state is set at the head of the for(;;)-loop, while the sleeping doesn't occur until nearly the end of the same loop. Is there a reason for the code in-between to run in TASK_INTERRUPTIBLE? If not, then would it make sense to use msleep_interruptible? Thanks for your input.

-Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors