char/snsc: reorder set_current_state() and
Subsystems (2)
PATCH 1/1 char/snsc: reorder set_current_state() and
Any comments would be, as always, appreciated.
-Nish
Description: Reorder add_wait_queue() and set_current_state() as a signal could be lost in between the two functions.
drivers/char/snsc.c +2 -2
@@ -192,8 +192,8 @@ scdrv_read(struct file *file, char __use } len =CHUNKSIZE ; -add_wait_queue (&sd->sd_rq, &wait);set_current_state (TASK_INTERRUPTIBLE ); +add_wait_queue (&sd->sd_rq, &wait);spin_unlock_irqrestore (&sd->sd_rlock, flags);schedule_timeout (SCDRV_TIMEOUT );
@@ -288,8 +288,8 @@ scdrv_write(struct file *file, const chareturn -EAGAIN ; } -add_wait_queue (&sd->sd_wq, &wait);set_current_state (TASK_INTERRUPTIBLE ); +add_wait_queue (&sd->sd_wq, &wait);spin_unlock_irqrestore (&sd->sd_wlock, flags);schedule_timeout (SCDRV_TIMEOUT );
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
maximilian attems
AppliedQuoted 8 lines · Nishanth Aravamudan
Any comments would be, as always, appreciated.
-Nish
Description: Reorder
add_wait_queue()andset_current_state()as a signal could be lost in between the two functions.Signed-off-by Nishanth Aravamudan <[email protected]>
applied to kjt,
to get further testing and to be shure it gets upstream.
thanks
--
maks
kernel janitor http://janitor.kernelnewbies.org/
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors