Skip to contentSkip to conversation

write gas check tmp file to O= directory

PATCH In review Olaf Hering 2 participants 3 messages Oct 24, 2004 – Oct 25, 2004

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 write gas check tmp file to O= directory

the tmp file should be in the O= directory.

btw, why does the mftb check not use '$?'?

arch/ppc/Makefile +3 -3
diff -purN linux-2.6.9.orig/arch/ppc/Makefile linux-2.6.9-olh/arch/ppc/Makefile
@@ -109,10 +109,10 @@ include/asm-$(ARCH)/offsets.h: arch/$(AR
 TOUT	:= .tmp_gas_check
 # Ensure this is binutils 2.12.1 (or 2.12.90.0.7) or later for altivec
 # instructions.
-AS_ALTIVEC	:= $(shell echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; echo $$?)
+AS_ALTIVEC	:= $(shell echo dssall | $(AS) -many -o $(objdir)$(TOUT) >/dev/null 2>&1 ; echo $$?)
 # gcc-3.4 and binutils-2.14 are a fatal combination.
 GCC_VERSION	:= $(call cc-version)
-BAD_GCC_AS	:= $(shell echo mftb 5 | $(AS) -mppc -many -o $(TOUT) >/dev/null 2>&1 && echo 0 || echo 1)
+BAD_GCC_AS	:= $(shell echo mftb 5 | $(AS) -mppc -many -o $(objdir)$(TOUT) >/dev/null 2>&1 && echo 0 || echo 1)
 
 checkbin:
 ifeq ($(GCC_VERSION)$(BAD_GCC_AS),03041)

@@ -132,5 +132,5 @@ endif
 
 CLEAN_FILES +=	include/asm-$(ARCH)/offsets.h \
 		arch/$(ARCH)/kernel/asm-offsets.s \
-		$(TOUT)
+		$(objdir)$(TOUT)
Signature · 3 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG
#1 lore raw
Quoted 1 line · Olaf Hering

the tmp file should be in the O= directory.

[snip]

arch/ppc/Makefile endif · line 135

Quoted 6 lines
arch/ppc/Makefile +1 -1
@@ -132,5 +132,5 @@ endif
 
 CLEAN_FILES +=	include/asm-$(ARCH)/offsets.h \
 		arch/$(ARCH)/kernel/asm-offsets.s \
-		$(TOUT)
+		$(objdir)$(TOUT)

Having to do this seems wrong. We don't need $(objdir) for any other generated file in CLEAN_FILES.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#2 lore raw
In reply to Olaf Hering
Quoted 1 line · Olaf Hering

the tmp file should be in the O= directory.

It is already. By changing AS_ALTIVEC to be just $(shell pwd) and adding an echo to checkbin we see:
echo /home/trini/work/kernel/pristine/amit-kgdb/linux-2.6.9/lopec

So this isn't an issue.

Quoted 2 lines

btw, why does the mftb check not use '$?'?

It was either that I saw different binutils fail with different exit codes, or testing for 03041 looked better than '0304255' or whatever the exit code was.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/