Skip to contentSkip to conversation

remove NET_HW_FLOWCONTROL

PATCH In review Arjan van de Ven 3 participants 4 messages Oct 25, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Arjan van de Ven

author
#0 lore raw

PATCH 1/1 remove NET_HW_FLOWCONTROL

CONFIG_NET_HW_FLOWCONTROL is entirely unused now, and superceded by NAPI in practice, so remove the dead code

Signed-off-by Arjan van de Ven <[email protected]>
include/linux/netdevice.h +0 -2
diff -purN linux-2.6.9/include/linux/netdevice.h linux/include/linux/netdevice.h
@@ -930,8 +930,6 @@ extern void		netdev_state_change(struct 
 /* Load a device via the kmod */
 extern void		dev_load(const char *name);
 extern void		dev_mcast_init(void);
-extern int		netdev_register_fc(struct net_device *dev, void (*stimul)(struct net_device *dev));
-extern void		netdev_unregister_fc(int bit);
 extern int		netdev_max_backlog;
 extern int		weight_p;
 extern unsigned long	netdev_fc_xoff;
net/Kconfig +0 -18
diff -purN linux-2.6.9/net/Kconfig linux/net/Kconfig
@@ -564,24 +564,6 @@ config WAN_ROUTER
 
 	  If unsure, say N.
 
-config NET_HW_FLOWCONTROL
-	bool "Forwarding between high speed interfaces"
-	depends on EXPERIMENTAL
-	---help---
-	  This option enables NIC (Network Interface Card) hardware throttling
-	  during periods of extreme congestion. At the moment only a couple
-	  of device drivers support it (really only one -- tulip, a modified
-	  8390 driver can be found at
-	  <ftp://ftp.tux.org/pub/net/ip-routing/fastroute/fastroute-8390.tar.gz>).
-
-	  Really, this option is applicable to any machine attached to a fast
-	  enough network, and even a 10 Mb NIC is able to kill a not very slow
-	  box, such as a 120MHz Pentium.
-
-	  However, do not say Y here if you did not experience any serious
-	  problems.
-
-
 menu "QoS and/or fair queueing"
 
 config NET_SCHED
net/core/dev.c +2 -91

131 lines not on this page · raw message

#1 lore raw
Quoted 2 lines · Arjan van de Ven

CONFIG_NET_HW_FLOWCONTROL is entirely unused now, and superceded by NAPI in practice, so remove the dead code

Ok with me. Jamal?

Jeff

#2 lore raw

nuke it.
I only know of one user of it in 2.4.x. If possible leave 2.4.x alone.

cheers,
jamal

Quoted 10 lines · Jeff Garzik
Quoted 2 lines · Arjan van de Ven

CONFIG_NET_HW_FLOWCONTROL is entirely unused now, and superceded by NAPI in practice, so remove the dead code

Ok with me. Jamal?

Jeff

#3 lore raw
Quoted 2 lines · jamal

nuke it.
I only know of one user of it in 2.4.x. If possible leave 2.4.x alone.

ok, will apply, thanks.

Jeff