Skip to contentSkip to conversation

Add p4-clockmod driver in x86-64

PATCH In review Venkatesh Pallipadi 2 participants 3 messages Oct 26, 2004 – Oct 28, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add p4-clockmod driver in x86-64

Add links for p4-clockmod driver in x86-64 cpufreq.

arch/x86_64/kernel/cpufreq/Makefile renamed from arch/x86_64/kernel/cpufreq/Makefile.org +4 -0
@@ -7,7 +7,11 @@ SRCDIR := ../../../i386/kernel/cpu/cpufr
 obj-$(CONFIG_X86_POWERNOW_K8) += powernow-k8.o
 obj-$(CONFIG_X86_SPEEDSTEP_CENTRINO) += speedstep-centrino.o
 obj-$(CONFIG_X86_ACPI_CPUFREQ) += acpi.o
+obj-$(CONFIG_X86_P4_CLOCKMOD) += p4-clockmod.o
+obj-$(CONFIG_X86_SPEEDSTEP_LIB) += speedstep-lib.o
 
 powernow-k8-objs := ${SRCDIR}/powernow-k8.o
 speedstep-centrino-objs := ${SRCDIR}/speedstep-centrino.o
 acpi-objs := ${SRCDIR}/acpi.o
+p4-clockmod-objs := ${SRCDIR}/p4-clockmod.o
+speedstep-lib-objs := ${SRCDIR}/speedstep-lib.o
arch/x86_64/kernel/cpufreq/Kconfig renamed from arch/x86_64/kernel/cpufreq/Kconfig.org +18 -0
@@ -94,5 +94,23 @@ config X86_ACPI_CPUFREQ_PROC_INTF
 
 	  If in doubt, say N.
 
+config X86_P4_CLOCKMOD
+	tristate "Intel Pentium 4 clock modulation"
+	depends on CPU_FREQ_TABLE
+	help
+	  This adds the CPUFreq driver for Intel Pentium 4 / XEON
+	  processors.
+
+	  For details, take a look at <file:Documentation/cpu-freq/>.
+
+	  If in doubt, say N.
+
+
+config X86_SPEEDSTEP_LIB
+        tristate
+        depends on (X86_P4_CLOCKMOD)
+        default (X86_P4_CLOCKMOD)
+
+
 endmenu
 
#1 lore raw
Quoted 2 lines · Venkatesh Pallipadi

Add links for p4-clockmod driver in x86-64 cpufreq.

Does this really make sense? I thought all shipping EM64T capable CPUs supported DBS? Why would you want clock modulation when you have DBS?

My own experience is that the clockmod driver is not very usable, it leads to extensive delays on a graphical desktop.

-Andi

#2 lore raw
In reply to Venkatesh Pallipadi
Quoted 2 lines · Venkatesh Pallipadi

Add links for p4-clockmod driver in x86-64 cpufreq.

I added it with a clarified description and made it dependent on CONFIG_EMBEDDED to prevent mistakes (perhaps that should be done on i386 too?)

Thanks.

-Andi

Here's the patch for your reference:

Add links for p4-clockmod driver in x86-64 cpufreq.

AK: Made it dependent on EMBEDDED because the driver is only useful in some special situations and should be normally not used.

arch/x86_64/kernel/cpufreq/Makefile +4 -0
Index: linux/arch/x86_64/kernel/cpufreq/Makefile
===================================================================
@@ -7,7 +7,11 @@
 obj-$(CONFIG_X86_POWERNOW_K8) += powernow-k8.o
 obj-$(CONFIG_X86_SPEEDSTEP_CENTRINO) += speedstep-centrino.o
 obj-$(CONFIG_X86_ACPI_CPUFREQ) += acpi.o
+obj-$(CONFIG_X86_P4_CLOCKMOD) += p4-clockmod.o
+obj-$(CONFIG_X86_SPEEDSTEP_LIB) += speedstep-lib.o
 
 powernow-k8-objs := ${SRCDIR}/powernow-k8.o
 speedstep-centrino-objs := ${SRCDIR}/speedstep-centrino.o
 acpi-objs := ${SRCDIR}/acpi.o
+p4-clockmod-objs := ${SRCDIR}/p4-clockmod.o
+speedstep-lib-objs := ${SRCDIR}/speedstep-lib.o
arch/x86_64/kernel/cpufreq/Kconfig +24 -0
Index: linux/arch/x86_64/kernel/cpufreq/Kconfig
===================================================================
@@ -88,5 +88,29 @@
 
 	  If in doubt, say N.
 
+config X86_P4_CLOCKMOD
+	tristate "Intel Pentium 4 clock modulation"
+	depends on CPU_FREQ_TABLE && EMBEDDED
+	help
+	  This adds the clock modulation driver for Intel Pentium 4 / XEON
+	  processors.  When enabled it will lower CPU temperature by skipping 
+	  clocks. 
+	  
+	  This driver should be only used in exceptional
+	  circumstances when very low power is needed because it causes severe 
+	  slowdowns and noticeable latencies.  Normally Speedstep should be used 
+	  instead.
+
+	  For details, take a look at <file:Documentation/cpu-freq/>.
+
+	  Unless you are absolutely sure say N.
+
+
+config X86_SPEEDSTEP_LIB
+        tristate
+        depends on (X86_P4_CLOCKMOD)
+        default (X86_P4_CLOCKMOD)
+
+
 endmenu