Skip to contentSkip to conversation

Doc/kbuild/makefiles.txt: check_gcc -> cc-option

PATCH In review Adrian Bunk 2 participants 2 messages Oct 27, 2004 – Oct 30, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Doc/kbuild/makefiles.txt: check_gcc -> cc-option

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It's not good to show the obsolete check_gcc in an example.

- --- linux-2.6.10-rc1-mm1-full/Documentation/kbuild/makefiles.txt.old 2004-10-27 19:58:24.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/Documentation/kbuild/makefiles.txt 2004-10-27 20:03:24.000000000 +0200
@@ -707,15 +707,17 @@
probe supported options:

#arch/i386/Makefile
- - check_gcc = $(shell if $(CC) $(1) -S -o /dev/null -xc \
- - /dev/null\ > /dev/null 2>&1; then echo "$(1)"; \
- - else echo "$(2)"; fi)
- - cflags-$(CONFIG_MCYRIXIII) += $(call check_gcc,\
- - -march=c3,-march=i486)

- - CFLAGS += $(cflags-y)
+ ...
+ cflags-$(CONFIG_MPENTIUMII) += $(call cc-option,\
+ -march=pentium2,-march=i686)
+ ...
+ # Disable unit-at-a-time mode ...
+ CFLAGS += $(call cc-option,-fno-unit-at-a-time)
+ ...

- - The above examples both utilise the trick that a config option expands
+
+ The first examples utilises the trick that a config option expands
to 'y' when selected.

     CFLAGS_KERNEL	$(CC) options specific for built-in

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgAQjmfzqmE8StAARAlpgAJwMs91KxFXt6J5CMIxX7CBmU+ck2QCggOtq 79uRYePvlHJEQ+lSKgNzzdQ=
=o4Vo
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 1 line · Adrian Bunk

It's not good to show the obsolete check_gcc in an example.

Agreed!
Applied,

Sam