Skip to contentSkip to conversation

DRM: remove unused functions

PATCH In review Adrian Bunk 2 participants 3 messages Oct 28, 2004 – Oct 31, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DRM: remove unused functions

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes two unused functions from DRM.

diffstat output:

 drivers/char/drm/i810_dma.c |   18 ------------------
 drivers/char/drm/i915_dma.c |   18 ------------------
 2 files changed, 36 deletions(-)

- --- linux-2.6.10-rc1-mm1-full/drivers/char/drm/i810_dma.c.old 2004-10-28 22:55:34.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/char/drm/i810_dma.c 2004-10-28 22:55:45.000000000 +0200
@@ -51,24 +51,6 @@
#define up_write up
#endif

- -static inline void i810_print_status_page(drm_device_t *dev)
- -{
- - drm_device_dma_t *dma = dev->dma;
- - drm_i810_private_t *dev_priv = dev->dev_private;
- - u32 *temp = dev_priv->hw_status_page;
- - int i;
- -

- -   	DRM_DEBUG(  "hw_status: Interrupt Status : %x\n", temp[0]);
- -   	DRM_DEBUG(  "hw_status: LpRing Head ptr : %x\n", temp[1]);
- -   	DRM_DEBUG(  "hw_status: IRing Head ptr : %x\n", temp[2]);

- - DRM_DEBUG( "hw_status: Reserved : %x\n", temp[3]);
- - DRM_DEBUG( "hw_status: Last Render: %x\n", temp[4]);
- - DRM_DEBUG( "hw_status: Driver Counter : %d\n", temp[5]);
- - for(i = 6; i < dma->buf_count + 6; i++) {
- - DRM_DEBUG( "buffer status idx : %d used: %d\n", i - 6, temp[i]);
- - }
- -}
- -
static drm_buf_t *i810_freelist_get(drm_device_t *dev)

 {
    	drm_device_dma_t *dma = dev->dma;

- --- linux-2.6.10-rc1-mm1-full/drivers/char/drm/i915_dma.c.old 2004-10-28 22:56:35.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/char/drm/i915_dma.c 2004-10-28 22:56:47.000000000 +0200
@@ -13,24 +13,6 @@
#include "i915_drm.h"
#include "i915_drv.h"

- -static inline void i915_print_status_page(drm_device_t * dev)
- -{
- - drm_i915_private_t *dev_priv = dev->dev_private;
- - u32 *temp = dev_priv->hw_status_page;
- -
- - if (!temp) {
- - DRM_DEBUG("no status page\n");
- - return;
- - }
- -
- - DRM_DEBUG("hw_status: Interrupt Status : %x\n", temp[0]);
- - DRM_DEBUG("hw_status: LpRing Head ptr : %x\n", temp[1]);
- - DRM_DEBUG("hw_status: IRing Head ptr : %x\n", temp[2]);
- - DRM_DEBUG("hw_status: Reserved : %x\n", temp[3]);
- - DRM_DEBUG("hw_status: Driver Counter : %d\n", temp[5]);
- -
- -}
- -
/* Really want an OS-independent resettable timer. Would like to have
* this loop run for (eg) 3 sec, but have the timer reset every time
* the head pointer changes, so that EBUSY only happens if the ring
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgW+HmfzqmE8StAARAttqAJ4h16xPCGoaSdpSQISliKrGQ4U6xwCgqOwN uU4Jwi0yuUSGoB4AbZHHN1U=
=Oppa
-----END PGP SIGNATURE-----

#1 lore raw

PATCH 1/1 DRM: remove unused functions

[ this time without the problems due to a digital signature... ]

The patch below removes two unused functions from DRM.

diffstat output:

 drivers/char/drm/i810_dma.c |   18 ------------------
 drivers/char/drm/i915_dma.c |   18 ------------------
 2 files changed, 36 deletions(-)
drivers/char/drm/i810_dma.c renamed from drivers/char/drm/i810_dma.c.old +0 -18
@@ -51,24 +51,6 @@
 #define up_write up
 #endif
 
-static inline void i810_print_status_page(drm_device_t *dev)
-{
-   	drm_device_dma_t *dma = dev->dma;
-      	drm_i810_private_t *dev_priv = dev->dev_private;
-	u32 *temp = dev_priv->hw_status_page;
-   	int i;
-
-   	DRM_DEBUG(  "hw_status: Interrupt Status : %x\n", temp[0]);
-   	DRM_DEBUG(  "hw_status: LpRing Head ptr : %x\n", temp[1]);
-   	DRM_DEBUG(  "hw_status: IRing Head ptr : %x\n", temp[2]);
-      	DRM_DEBUG(  "hw_status: Reserved : %x\n", temp[3]);
-	DRM_DEBUG(  "hw_status: Last Render: %x\n", temp[4]);
-   	DRM_DEBUG(  "hw_status: Driver Counter : %d\n", temp[5]);
-   	for(i = 6; i < dma->buf_count + 6; i++) {
-	   	DRM_DEBUG( "buffer status idx : %d used: %d\n", i - 6, temp[i]);
-	}
-}
-
 static drm_buf_t *i810_freelist_get(drm_device_t *dev)
 {
    	drm_device_dma_t *dma = dev->dma;
drivers/char/drm/i915_dma.c renamed from drivers/char/drm/i915_dma.c.old +0 -18
@@ -13,24 +13,6 @@
 #include "i915_drm.h"
 #include "i915_drv.h"
 
-static inline void i915_print_status_page(drm_device_t * dev)
-{
-	drm_i915_private_t *dev_priv = dev->dev_private;
-	u32 *temp = dev_priv->hw_status_page;
-
-	if (!temp) {
-		DRM_DEBUG("no status page\n");
-		return;
-	}
-
-	DRM_DEBUG("hw_status: Interrupt Status : %x\n", temp[0]);
-	DRM_DEBUG("hw_status: LpRing Head ptr : %x\n", temp[1]);
-	DRM_DEBUG("hw_status: IRing Head ptr : %x\n", temp[2]);
-	DRM_DEBUG("hw_status: Reserved : %x\n", temp[3]);
-	DRM_DEBUG("hw_status: Driver Counter : %d\n", temp[5]);
-
-}
-
 /* Really want an OS-independent resettable timer.  Would like to have
  * this loop run for (eg) 3 sec, but have the timer reset every time
  * the head pointer changes, so that EBUSY only happens if the ring