Skip to contentSkip to conversation

i2c it87.c: remove an unused function

PATCH New Adrian Bunk 3 participants 4 messages Oct 28, 2004 – Nov 5, 2004

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 i2c it87.c: remove an unused function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unused function from drivers/i2c/chips/it87.c

diffstat output:

 drivers/i2c/chips/it87.c |    7 -------
 1 files changed, 7 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>

- --- linux-2.6.10-rc1-mm1-full/drivers/i2c/chips/it87.c.old 2004-10-28 23:00:26.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/i2c/chips/it87.c 2004-10-28 23:00:37.000000000 +0200
@@ -56,13 +56,6 @@
#define PME 0x04 /* The device with the fan registers in it */
#define DEVID 0x20 /* Register: Device ID */

- -static inline void
- -superio_outb(int reg, int val)
- -{
- - outb(reg, REG);
- - outb(val, VAL);
- -}
- -
static inline int
superio_inb(int reg)
{

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgXC3mfzqmE8StAARAnheAJ4oIAZ/LT/MvhtbLjQpkCokdnkCzQCeMUx+ 0hf83OAbIcIyj95pPV3hUWg=
=AgjG
-----END PGP SIGNATURE-----

author
#1 lore raw

PATCH 1/1 i2c it87.c: remove an unused function

[ this time without the problems due to a digital signature... ]

The patch below removes an unused function from drivers/i2c/chips/it87.c

diffstat output:

 drivers/i2c/chips/it87.c |    7 -------
 1 files changed, 7 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
drivers/i2c/chips/it87.c renamed from drivers/i2c/chips/it87.c.old +0 -7
@@ -56,13 +56,6 @@
 #define PME	0x04	/* The device with the fan registers in it */
 #define	DEVID	0x20	/* Register: Device ID */
 
-static inline void
-superio_outb(int reg, int val)
-{
-	outb(reg, REG);
-	outb(val, VAL);
-}
-
 static inline int
 superio_inb(int reg)
 {
#2 lore raw

Hi Adrian & all,

drivers/i2c/chips/it87.c line 60

Quoted 4 lines

The patch below removes an unused function from drivers/i2c/chips/it87.c (...)

drivers/i2c/chips/it87.c renamed from drivers/i2c/chips/it87.c.old +0 -2
-static inline void
-superio_outb(int reg, int val)

For information, this function was most likely there for the case we would implement the force_addr module parameter for this driver (see the w83627hf driver in the same directory for an example of that).

That said, I have no objection to the removal of this function. We can still add it back later if we ever need it.

Thanks,
Jean

Applied
#3 lore raw
In reply to Adrian Bunk
Quoted 11 lines · Adrian Bunk

[ this time without the problems due to a digital signature... ]

The patch below removes an unused function from drivers/i2c/chips/it87.c

diffstat output:

 drivers/i2c/chips/it87.c |    7 -------
 1 files changed, 7 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>

Applied, thanks.

greg k-h