Skip to contentSkip to conversation

JFS: make some symbols static

PATCH In review Adrian Bunk 2 participants 2 messages Oct 30, 2004 – Nov 1, 2004 JFS filesystem

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 JFS: make some symbols static

The patch below makes some JFS symbols that are only used inside the file they are defined in static.

diffstat output:

 fs/jfs/jfs_logmgr.c   |    8 ++++----
 fs/jfs/jfs_metapage.c |    2 +-
 fs/jfs/jfs_txnmgr.c   |    4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
fs/jfs/jfs_logmgr.c renamed from fs/jfs/jfs_logmgr.c.old +4 -4
@@ -161,9 +161,9 @@
 /*
  * Global list of active external journals
  */
-LIST_HEAD(jfs_external_logs);
-struct jfs_log *dummy_log = NULL;
-DECLARE_MUTEX(jfs_log_sem);
+static LIST_HEAD(jfs_external_logs);
+static struct jfs_log *dummy_log = NULL;
+static DECLARE_MUTEX(jfs_log_sem);
 
 /*
  * external references

@@ -205,7 +205,7 @@
  *	statistics
  */
 #ifdef CONFIG_JFS_STATISTICS
-struct lmStat {
+static struct lmStat {
 	uint commit;		/* # of commit */
 	uint pagedone;		/* # of page written */
 	uint submitted;		/* # of pages submitted */
fs/jfs/jfs_metapage.c renamed from fs/jfs/jfs_metapage.c.old +1 -1
@@ -31,7 +31,7 @@
 static spinlock_t meta_lock = SPIN_LOCK_UNLOCKED;
 
 #ifdef CONFIG_JFS_STATISTICS
-struct {
+static struct {
 	uint	pagealloc;	/* # of page allocations */
 	uint	pagefree;	/* # of page frees */
 	uint	lockwait;	/* # of sleeping lock_metapage() calls */
fs/jfs/jfs_txnmgr.c renamed from fs/jfs/jfs_txnmgr.c.old +2 -2
@@ -80,7 +80,7 @@
 int jfs_tlocks_low;		/* Indicates low number of available tlocks */
 
 #ifdef CONFIG_JFS_STATISTICS
-struct {
+static struct {
 	uint txBegin;
 	uint txBegin_barrier;
 	uint txBegin_lockslow;

@@ -152,7 +152,7 @@
 /*
  *      statistics
  */
-struct {
+static struct {
 	tid_t maxtid;		/* 4: biggest tid ever used */
 	lid_t maxlid;		/* 4: biggest lid ever used */
 	int ntid;		/* 4: # of transactions performed */
#1 lore raw
Quoted 4 lines · Adrian Bunk

The patch below makes some JFS symbols that are only used inside the file they are defined in static.

...

Looks sane. I'll apply this and push it to Andrew.

Thanks,
Shaggy

Signature · 3 lines
Dave Kleikamp
IBM Linux Technology Center
[email protected]