Skip to contentSkip to conversation

let FW_LOADER select HOTPLUG

PATCH In review Adrian Bunk 2 participants 4 messages Oct 30, 2004

Subsystems (3)
Network drivers Driver core Networking drivers (wireless)
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 let FW_LOADER select HOTPLUG

If it wasn't for external modules, FW_LOADER wasn't user-visible. Let FW_LOADER select HOTPLUG To make the dependencies easier for users.

Signed-off-by Adrian Bunk <[email protected]>
drivers/base/Kconfig renamed from drivers/base/Kconfig.old +1 -1
@@ -20,7 +20,7 @@
 
 config FW_LOADER
 	tristate "Hotplug firmware loading support"
-	depends on HOTPLUG
+	select HOTPLUG
 	---help---
 	  This option is provided for the case where no in-kernel-tree modules
 	  require hotplug firmware loading support, but a module built outside
drivers/net/wireless/Kconfig renamed from drivers/net/wireless/Kconfig.old +2 -1
@@ -309,9 +309,10 @@
 
 comment "Prism GT/Duette 802.11(a/b/g) PCI/Cardbus support"
 	depends on NET_RADIO && PCI
+
 config PRISM54
 	tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus' 
-	depends on PCI && NET_RADIO && EXPERIMENTAL && HOTPLUG
+	depends on PCI && NET_RADIO && EXPERIMENTAL
 	select FW_LOADER
 	---help---
 	  Enable PCI and Cardbus support for the following chipset based cards:
drivers/net/tokenring/Kconfig renamed from drivers/net/tokenring/Kconfig.old +1 -1
@@ -84,7 +84,7 @@
 
 config TMS380TR
 	tristate "Generic TMS380 Token Ring ISA/PCI adapter support"
-	depends on TR && (PCI || ISA) && HOTPLUG
+	depends on TR && (PCI || ISA)
 	select FW_LOADER
 	---help---
 	  This driver provides generic support for token ring adapters
#1 lore raw
Quoted 3 lines · Adrian Bunk

If it wasn't for external modules, FW_LOADER wasn't user-visible. Let FW_LOADER select HOTPLUG To make the dependencies easier for users.

You know what I'm going to say about this patch, so I'll won't repeat, except to say it has to do with select on user visible symbols.

Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
author
#2 lore raw
Quoted 7 lines · Russell King
Quoted 3 lines · Adrian Bunk

If it wasn't for external modules, FW_LOADER wasn't user-visible. Let FW_LOADER select HOTPLUG To make the dependencies easier for users.

You know what I'm going to say about this patch, so I'll won't repeat, except to say it has to do with select on user visible symbols.

I can send a patch that changes all dependencies on HOTPLUG to selects. Would thids be acceptable?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 11 lines · Adrian Bunk
Quoted 7 lines · Russell King
Quoted 3 lines · Adrian Bunk

If it wasn't for external modules, FW_LOADER wasn't user-visible. Let FW_LOADER select HOTPLUG To make the dependencies easier for users.

You know what I'm going to say about this patch, so I'll won't repeat, except to say it has to do with select on user visible symbols.

I can send a patch that changes all dependencies on HOTPLUG to selects. Would thids be acceptable?

Yup, especially as you can use the same argument as the FW_LOADER case applies to the PCMCIA case, or PCI hotplug case.

Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core