PKT_SCHED: break is not enough to stop walking

PATCH Applied Thomas Graf 2 participants 2 messages Oct 29, 2004 – Nov 2, 2004

Subsystems (3)

Networking Network drivers Traffic control (tc)

lore

Share & tools

lore

Thomas Graf

author

2004-10-29 00:29 UTC #0 lore raw

PATCH 1/1 PKT_SCHED: break is not enough to stop walking

break is not enough to escape from the walking loops, since multiple encapsulated loops are used to traverse the hash tables.

Signed-off-by Thomas Graf <[email protected]>

net/sched/cls_fw.c +1 -1

@@ -292,7 +292,7 @@
 			}
 			if (arg->fn(tp, (unsigned long)f, arg) < 0) {
 				arg->stop = 1;
-				break;
+				return;
 			}
 			arg->count++;
 		}

net/sched/cls_route.c +1 -1

@@ -541,7 +541,7 @@
 					}
 					if (arg->fn(tp, (unsigned long)f, arg) < 0) {
 						arg->stop = 1;
-						break;
+						return;
 					}
 					arg->count++;
 				}

net/sched/cls_rsvp.h +1 -1

@@ -604,7 +604,7 @@
 					}
 					if (arg->fn(tp, (unsigned long)f, arg) < 0) {
 						arg->stop = 1;
-						break;
+						return;
 					}
 					arg->count++;
 				}

David S. Miller

maintainer Applied

2004-11-02 00:58 UTC #1 lore raw

Quoted 4 lines · On Fri, 29 Oct 2004 02:29:58 +0200 Thomas Graf <[email protected]> wrote:

break is not enough to escape from the walking loops, since multiple encapsulated loops are used to traverse the hash tables.
Signed-off-by Thomas Graf <[email protected]>

Applied, thanks for doing this backport Thomas.