Skip to contentSkip to conversation

s3c2410 i2c build fix

PATCH New Ben Dooks 3 participants 3 messages May 19, 2005

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 s3c2410 i2c build fix

the attach patch seems to have gotten lost somewhere down the line, it fixes an include error, as well as the removal of the I2C_ALGO_S3C2410 which seems to have crept back in.

-------------- next part --------------

drivers/i2c/busses/i2c-s3c2410.c +1 -2
@@ -36,6 +36,7 @@
 
 #include <asm/hardware.h>
 #include <asm/irq.h>
+#include <asm/io.h>
 
 #include <asm/hardware/clock.h>
 #include <asm/arch/regs-gpio.h>
@@ -534,7 +535,6 @@
 
 static struct i2c_algorithm s3c24xx_i2c_algorithm = {
 	.name			= "S3C2410-I2C-Algorithm",
-	.id			= I2C_ALGO_S3C2410,
 	.master_xfer		= s3c24xx_i2c_xfer,
 };
 
@@ -543,7 +543,6 @@
 	.wait	= __WAIT_QUEUE_HEAD_INITIALIZER(s3c24xx_i2c.wait),
 	.adap	= {
 		.name			= "s3c2410-i2c",
-		.id			= I2C_ALGO_S3C2410,
 		.algo			= &s3c24xx_i2c_algorithm,
 		.retries		= 2,
 	},
#1 lore raw

PATCH 1/1 s3c2410 i2c build fix

Hi Ben,

Quoted 4 lines

the attach patch seems to have gotten lost somewhere down the line, it fixes an include error, as well as the removal of the I2C_ALGO_S3C2410 which seems to have crept back in.

I don't think it was lost, Greg has it in its bk-i2c tree, has can been seen here:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm2/broken-out/bk-i2c.patch

Signature · 2 lines
Jean Delvare
http://khali.linux-fr.org/
#2 lore raw

PATCH 1/1 s3c2410 i2c build fix

In reply to Ben Dooks
Quoted 11 lines · Jean Delvare

Hi Ben,

Quoted 4 lines

the attach patch seems to have gotten lost somewhere down the line, it fixes an include error, as well as the removal of the I2C_ALGO_S3C2410 which seems to have crept back in.

I don't think it was lost, Greg has it in its bk-i2c tree, has can been seen here:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm2/broken-out/bk-i2c.patch

thanks, I didn't think to look in the mm patches.

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'