fbdev: atyfb_base.c requires atyfb_cursor()

PATCH In review Antonino A. Daplas 3 participants 6 messages Nov 2, 2004 – Nov 3, 2004 Framebuffer layer

Share & tools

Antonino A. Daplas

author

2004-11-02 11:47 UTC #0 lore raw

PATCH 7/8 fbdev: atyfb_base.c requires atyfb_cursor()

atyfb_base.c requires atyfb_cursor, but it is only available for linking if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.

Signed-off-by Olaf Hering <[email protected]>

Signed-off-by Antonino Daplas <[email protected]>

---

 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/video/aty/Makefile +2 -2

diff -Nru a/drivers/video/aty/Makefile b/drivers/video/aty/Makefile
@@ -2,9 +2,9 @@
 obj-$(CONFIG_FB_ATY128) += aty128fb.o
 obj-$(CONFIG_FB_RADEON) += radeonfb.o
 
-atyfb-y				:= atyfb_base.o mach64_accel.o
+atyfb-y				:= atyfb_base.o mach64_accel.o mach64_cursor.o
 atyfb-$(CONFIG_FB_ATY_GX)	+= mach64_gx.o
-atyfb-$(CONFIG_FB_ATY_CT)	+= mach64_ct.o mach64_cursor.o
+atyfb-$(CONFIG_FB_ATY_CT)	+= mach64_ct.o
 atyfb-objs			:= $(atyfb-y)
 
 radeonfb-y			:= radeon_base.o radeon_pm.o radeon_monitor.o radeon_accel.o

-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click

ramprasad

2004-11-02 13:06 UTC #1 lore raw

S1D13506 CRT

Hi All,
I am using 2.4.19-rmk7-pxa1 kernel.I have an S1D13506 LCD/CRT
controller. has anybody got this working on PXA processor.any hint on how to go about. I have to configure for CRT display.

Thanks in advance,
Ramprasad

Ville Syrjälä

2004-11-02 13:58 UTC #2 lore raw

In reply to Antonino A. Daplas

Quoted 3 lines · Antonino A. Daplas

atyfb_base.c requires atyfb_cursor, but it is only available for linking if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.

Here's a better fix. It was a part of my swcursor patch which was partially included. Looks like Alex accidentally dropped this part.

Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem

Signed-off-by Ville Syrjala <[email protected]>

---

 atyfb_base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

drivers/video/aty/atyfb_base.c +1 -1

diff -Nur a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
@@ -292,7 +292,7 @@
 	.fb_fillrect	= atyfb_fillrect,
 	.fb_copyarea	= atyfb_copyarea,
 	.fb_imageblit	= atyfb_imageblit,
-	.fb_cursor	= atyfb_cursor,
+	.fb_cursor	= soft_cursor,
 #ifdef __sparc__
 	.fb_mmap	= atyfb_mmap,
 #endif

Signature · 10 lines

Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id065&op=click

Antonino A. Daplas

author

2004-11-02 21:31 UTC #3 lore raw

Quoted 5 lines · Ville Syrjälä

Quoted 3 lines · Antonino A. Daplas
atyfb_base.c requires atyfb_cursor, but it is only available for linking if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.

Quoted 8 lines

Here's a better fix. It was a part of my swcursor patch which was partially included. Looks like Alex accidentally dropped this part.
Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem

If I read Alex's patch correctly, it looks like the aty has a working hardware cursor implementation, is this correct? Then a better patch may be to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.

Tony

Ville Syrjälä

2004-11-02 22:26 UTC #4 lore raw

Quoted 10 lines · Antonino A. Daplas

Quoted 9 lines · Ville Syrjälä
Quoted 3 lines · Antonino A. Daplas
atyfb_base.c requires atyfb_cursor, but it is only available for linking if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.
Here's a better fix. It was a part of my swcursor patch which was partially included. Looks like Alex accidentally dropped this part.

Quoted 8 lines

Quoted 4 lines
Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem
If I read Alex's patch correctly, it looks like the aty has a working hardware cursor implementation, is this correct? Then a better patch may be to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.

That is how things work with this patch. aty_init_cursor() sets fb_cursor to atyfb_cursor.

Signature · 10 lines

Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id065&op=click

Antonino A. Daplas

author

2004-11-03 02:40 UTC #5 lore raw

Quoted 15 lines · Ville Syrjälä

Quoted 14 lines · Antonino A. Daplas
Quoted 12 lines · Ville Syrjälä
Quoted 3 lines · Antonino A. Daplas
atyfb_base.c requires atyfb_cursor, but it is only available for linking if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.
Here's a better fix. It was a part of my swcursor patch which was partially included. Looks like Alex accidentally dropped this part.
Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem

Quoted 6 lines

Quoted 3 lines
If I read Alex's patch correctly, it looks like the aty has a working hardware cursor implementation, is this correct? Then a better patch may be to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.
That is how things work with this patch. aty_init_cursor() sets fb_cursor to atyfb_cursor.

Ah, ok, did not see that.

Tony