Skip to contentSkip to conversation

Minor fix of RCU documentation

PATCH In review Jan Kasprzak 2 participants 2 messages Nov 2, 2004 – Nov 3, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Minor fix of RCU documentation

Hello, all!

the attached patch fixes an incorrect example in Documentation/RCU/listRCU.txt
- the "original" lock-based code should not call RCU functions, of course.

-Yenya

Documentation/RCU/listRCU.txt renamed from Documentation/RCU/listRCU.txt.orig +1 -1
@@ -82,7 +82,7 @@
 		list_for_each_entry(e, list, list) {
 			if (!audit_compare_rule(rule, &e->rule)) {
 				list_del(&e->list);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				write_unlock(&auditsc_lock);
 				return 0;
 			}
 		}
Signature · 3 lines
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/   Czech Linux Homepage: http://www.linux.cz/ |
Quoted 2 lines

Whatever the Java applications and desktop dances may lead to, Unix will <
still be pushing the packets around for a quite a while. --Rob Pike <

Acked-by on v1 1/1
#1 lore raw

Good catch! Andrew, please apply.

Thanx, Paul

Quoted 34 lines · Jan Kasprzak

Hello, all!

the attached patch fixes an incorrect example in Documentation/RCU/listRCU.txt
- the "original" lock-based code should not call RCU functions, of course.

-Yenya

Documentation/RCU/listRCU.txt renamed from Documentation/RCU/listRCU.txt.orig +1 -1
@@ -82,7 +82,7 @@
 		list_for_each_entry(e, list, list) {
 			if (!audit_compare_rule(rule, &e->rule)) {
 				list_del(&e->list);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				write_unlock(&auditsc_lock);
 				return 0;
 			}
 		}
Signature · 4 lines
-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/   Czech Linux Homepage: http://www.linux.cz/ |
Quoted 2 lines

Whatever the Java applications and desktop dances may lead to, Unix will <
still be pushing the packets around for a quite a while. --Rob Pike <

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/