Skip to contentSkip to conversation

Toshiba Satellite, Synaptics & keyboard problems

RFT/PATCH Dmitry Torokhov 3 participants 4 messages Nov 8, 2004

lore
Share & tools
lore
#0 lore raw

Hi,

If anyone experiencing keyboard getting "stuck" when you use Synaptics touchpad in native mode on Toshiba Satellite type notebooks it seems that lowering rate to 40 pps (which is roughly the same as standard PS/2 rate bytewise) helps.

Please try the patch below (should apply to -mm tree) and see if it helps any. If not using -mm tree just use "psmouse.rate=40" or "modprobe psmouse rate=40" to check if fix is working for you and let me know.

Thanks!

Signature · 64 lines
Dmitry


===================================================================


[email protected], 2004-11-08 01:51:37-05:00, [email protected]
  Input: synaptics - use DMI to detect Toshiba Satellite notebooks
         and automatically reduce touchpad reporting rate to 40 pps
         as they have trouble handling high rate (80 pps).
  
  Signed-off-by: Dmitry Torokhov <[email protected]>


 synaptics.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+)


===================================================================



diff -Nru a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
--- a/drivers/input/mouse/synaptics.c	2004-11-08 01:52:54 -05:00
+++ b/drivers/input/mouse/synaptics.c	2004-11-08 01:52:54 -05:00
@@ -604,6 +604,20 @@
 	return 0;
 }
 
+#if defined(__i386__)
+#include <linux/dmi.h>
+static struct dmi_system_id synaptics_dmi_table[] = {
+	{
+		.ident = "Toshiba Satellite",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME , "Satellite"),
+		},
+	},
+	{ }
+};
+#endif
+
 int synaptics_init(struct psmouse *psmouse)
 {
 	struct synaptics_data *priv;
@@ -636,6 +650,18 @@
 	psmouse->disconnect = synaptics_disconnect;
 	psmouse->reconnect = synaptics_reconnect;
 	psmouse->pktsize = 6;
+
+#if defined(__i386__)
+	/*
+	 * Toshiba's KBC seems to have trouble handling data from
+	 * Synaptics as full rate, switch to lower rate which is roughly
+	 * thye same as rate of standard PS/2 mouse.
+	 */
+	if (dmi_check_system(synaptics_dmi_table)) {
+		printk(KERN_INFO "synaptics: Toshiba Satellite detected, limiting rate to 40pps.\n");
+		psmouse->rate = 40;
+	}
+#endif
 
 	return 0;
#1 lore raw
Quoted 10 lines · Dmitry Torokhov

Hi,

If anyone experiencing keyboard getting "stuck" when you use Synaptics touchpad in native mode on Toshiba Satellite type notebooks it seems that lowering rate to 40 pps (which is roughly the same as standard PS/2 rate bytewise) helps.

Please try the patch below (should apply to -mm tree) and see if it helps any. If not using -mm tree just use "psmouse.rate=40" or "modprobe psmouse rate=40" to check if fix is working for you and let me know.

I have problems with "no keyboard" since Kernel 2.6.9. I am not using a -mm tree and booting with "psmouse.rate=40" does
_not_ fix the problem :-( (tested with 2.6.9 and 2.6.10-rc1).

As soon as X is started I have no keyboard.
My box is a Acer Travelmate 290 notebook with synaptics/alps touchpad.

Juergen.

Quoted 74 lines

Thanks!

Signature · 23 lines
Dmitry


===================================================================


[email protected], 2004-11-08 01:51:37-05:00, [email protected]
  Input: synaptics - use DMI to detect Toshiba Satellite notebooks
         and automatically reduce touchpad reporting rate to 40 pps
         as they have trouble handling high rate (80 pps).
  
  Signed-off-by: Dmitry Torokhov <[email protected]>


 synaptics.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+)


===================================================================



diff -Nru a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
drivers/input/mouse/synaptics.c +26 -1
@@ -604,6 +604,20 @@
 	return 0;
 }
 
+#if defined(__i386__)
+#include <linux/dmi.h>
+static struct dmi_system_id synaptics_dmi_table[] = {
+	{
+		.ident = "Toshiba Satellite",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME , "Satellite"),
+		},
+	},
+	{ }
+};
+#endif
+
 int synaptics_init(struct psmouse *psmouse)
 {
 	struct synaptics_data *priv;
@@ -636,6 +650,18 @@
 	psmouse->disconnect = synaptics_disconnect;
 	psmouse->reconnect = synaptics_reconnect;
 	psmouse->pktsize = 6;
+
+#if defined(__i386__)
+	/*
+	 * Toshiba's KBC seems to have trouble handling data from
+	 * Synaptics as full rate, switch to lower rate which is roughly
+	 * thye same as rate of standard PS/2 mouse.
+	 */
+	if (dmi_check_system(synaptics_dmi_table)) {
+		printk(KERN_INFO "synaptics: Toshiba Satellite detected, limiting rate to 40pps.\n");
+		psmouse->rate = 40;
+	}
+#endif
 
 	return 0;
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 12 lines · Juergen Quade
Quoted 10 lines · Dmitry Torokhov

Hi,

If anyone experiencing keyboard getting "stuck" when you use Synaptics touchpad in native mode on Toshiba Satellite type notebooks it seems that lowering rate to 40 pps (which is roughly the same as standard PS/2 rate bytewise) helps.

Please try the patch below (should apply to -mm tree) and see if it helps any. If not using -mm tree just use "psmouse.rate=40" or "modprobe psmouse rate=40" to check if fix is working for you and let me know.

Quoted 8 lines

I have problems with "no keyboard" since Kernel 2.6.9. I am not using a -mm tree and booting with "psmouse.rate=40" does
_not_ fix the problem :-( (tested with 2.6.9 and 2.6.10-rc1).

As soon as X is started I have no keyboard.
My box is a Acer Travelmate 290 notebook with synaptics/alps touchpad.

Well, this one is pretty easy - make sure that you have a recent version of Synaptics X driver and change protocol in your XF86Config to "auto-dev". (most likely you wree using /dev/input/exentX as your device and in 2.6.9 your keyboard and touchpad swapped their event devices).

Signature · 1 line
Dmitry
#3 lore raw
Quoted 6 lines

...
Well, this one is pretty easy - make sure that you have a recent version of Synaptics X driver and change protocol in your XF86Config to "auto-dev". (most likely you wree using /dev/input/exentX as your device and in 2.6.9 your keyboard and touchpad swapped their event devices).

Gotcha!
Your guess was right. Thanks a lot!

Juergen.