Skip to contentSkip to conversation

remove unnecessary pm_idle comment

PATCH Applied Eric Brower 2 participants 2 messages Nov 10, 2004 – Nov 11, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove unnecessary pm_idle comment

This is a trivial matter, but we ought to remove the 2.6 kernel comments that indicate confusion over the conditional use of pm_idle in process.c-- systems with APC or PMC (basically, SS4/5 and Voyager) have the ability to idle the CPU and do so. Please see .../kernel/apc.c or pmc.c for details.

Please review attached patch-- no need for confusion.

Thanks,
E

sparc/kernel/process.c renamed from sparc/kernel/process.c.orig +2 -2
@@ -45,7 +45,7 @@
 
 /* 
  * Power management idle function 
- * Set in pm platform drivers
+ * Set in pm platform drivers (apc.c and pmc.c)
  */
 void (*pm_idle)(void);
 
@@ -122,7 +122,7 @@
 		}
 
 		while((!need_resched()) && pm_idle) {
-			(*pm_idle)();		/* XXX Huh? On sparc?! */
+			(*pm_idle)();
 		}
 
 		schedule();
#1 lore raw
Quoted 7 lines · On Wed, 10 Nov 2004 14:51:07 -0800 Eric Brower <[email protected]> wrote:

This is a trivial matter, but we ought to remove the 2.6 kernel comments that indicate confusion over the conditional use of pm_idle in process.c-- systems with APC or PMC (basically, SS4/5 and Voyager) have the ability to idle the CPU and do so. Please see .../kernel/apc.c or pmc.c for details.

Please review attached patch-- no need for confusion.

Applied, thanks Eric.